Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightworks: use old portaudio 2014 #33899

Merged
merged 2 commits into from Jan 15, 2018
Merged

Lightworks: use old portaudio 2014 #33899

merged 2 commits into from Jan 15, 2018

Conversation

antonxy
Copy link
Contributor

@antonxy antonxy commented Jan 15, 2018

Motivation for this change

Lightworks crashed at startup because of a breaking ABI change from PortAudio 2014 to 2016, see #25552 (comment) for more details.

I added a portaudio2014 package for the old version of portaudio so lightworks can use this until a lightworks version using the new portaudio is released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Needed e.g. for lightworks package as there was a breaking ABI change
between portaudio 2014 and 2016
There was an ABI change in portaudio 2016 which caused lightworks to
fail to start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants