Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hypothesis-python: 3.11.1 -> 3.27.0 #33983

Closed
wants to merge 2 commits into from
Closed

hypothesis-python: 3.11.1 -> 3.27.0 #33983

wants to merge 2 commits into from

Conversation

va1entin
Copy link
Contributor

Motivation for this change

I wanted to update PyNaCl in Nixpkgs, but it's tests require this version of hypothesis. I chose 3.27.0 because that's the earliest one with the features needed by pynacl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md. - no maintainer, fits otherwise

@va1entin va1entin requested a review from FRidh as a code owner January 17, 2018 16:24
@Mic92
Copy link
Member

Mic92 commented Jan 17, 2018

This PR should go to the staging branch first rather then master since it rebuilds many packages.

@va1entin va1entin changed the base branch from master to staging January 17, 2018 16:48
@va1entin
Copy link
Contributor Author

Thanks @Mic92
I changed the base branch to staging

@FRidh FRidh self-assigned this Jan 17, 2018
@FRidh
Copy link
Member

FRidh commented Jan 17, 2018

This change can be merged in a later batch after a Hydra job to check whether builds still succeed.

@FRidh FRidh mentioned this pull request Jan 20, 2018
Merged
8 tasks
@FRidh
Copy link
Member

FRidh commented Jan 20, 2018

I've included the changes in #34077.

@FRidh FRidh closed this Jan 20, 2018
@va1entin va1entin deleted the testing branch January 20, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@va1entin @Mic92 @FRidh @GrahamcOfBorg @Janik-Haag