Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package updates #34553

Merged
merged 77 commits into from Feb 4, 2018
Merged

Python package updates #34553

merged 77 commits into from Feb 4, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

https://hydra.nixos.org/jobset/nixpkgs/python-unstable

@FRidh FRidh changed the base branch from master to staging February 3, 2018 11:45
@dotlambda
Copy link
Member

Please add dotlambda@130542e

@dotlambda
Copy link
Member

I also updated typing: dotlambda/nixpkgs@fd753e1
I however had to disable tests for Python 3.6. I must say I can't really follow python/typing#280 but typing should have any effect for Python 3.5 or later anyway.
Is there a way to add typing to buildInputs only for Python 3.4 and below? For example by making it null otherwise? This could however lead to unsatisfied requirements.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to remove all names in the updated derivations?

@FRidh
Copy link
Member Author

FRidh commented Feb 3, 2018

Is there a way to add typing to buildInputs only for Python 3.4 and below? For example by making it null otherwise? This could however lead to unsatisfied requirements.

buildInputs = [ ] ++ optionals pythonOlder "3.5" [ typing ];

Other solution we use mostly for backports:

typing = if pythonAtLeast "3.5" then null else buildPythonPackage rec { ... };

Wouldn't it make sense to remove all names in the updated derivations?

Feel free to create a commit that removes all of them. These updates are generated automatically.

@dotlambda
Copy link
Member

I had already tried the second solution but that would cause packages requiring typing in their setup.py to fail to build. So I guess it is best left as is.

@dotlambda
Copy link
Member

Don't you want to include the typing update?

@grahamc
Copy link
Member

grahamc commented Feb 3, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘spyder-3.2.6’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/science/spyder/default.nix:47 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@FRidh
Copy link
Member Author

FRidh commented Feb 3, 2018

(@grahamc vs @GrahamcOfBorg 😆 )

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘spyder-3.2.6’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/science/spyder/default.nix:47 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Requirement already satisfied: pylint in /nix/store/hg7z39d2ifi0i83njd4j4xswbsfdfkjf-python2.7-pylint-1.8.2/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: jedi>=0.9.0 in /nix/store/mzaj8hm6x9szwskh1z6gmm4vcl4bz3ik-python2.7-jedi-0.11.1/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: pycodestyle in /nix/store/47fniyjczd3nacnym72mya9i4w8kinkz-python2.7-pycodestyle-2.3.1/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: psutil in /nix/store/96ral8lnx118a1qccink2z2bhsmyg7ar-python2.7-psutil-5.4.3/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: nbconvert in /nix/store/18mqml1f4gb9ya5w2plxvkf56bds2hh1-python2.7-nbconvert-5.3.1/lib/python2.7/site-packages (from spyder==3.2.6)
Collecting pyopengl; platform_system == "Linux" (from spyder==3.2.6)
  Could not find a version that satisfies the requirement pyopengl; platform_system == "Linux" (from spyder==3.2.6) (from versions: )
No matching distribution found for pyopengl; platform_system == "Linux" (from spyder==3.2.6)
builder for ‘/nix/store/xqwzwxz29ipxvf081sxd44qpxk4bfqgs-spyder-3.2.6.drv’ failed with exit code 1
error: build of ‘/nix/store/xqwzwxz29ipxvf081sxd44qpxk4bfqgs-spyder-3.2.6.drv’ failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘spyder-3.2.6’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/science/spyder/default.nix:47 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Requirement already satisfied: pylint in /nix/store/hg7z39d2ifi0i83njd4j4xswbsfdfkjf-python2.7-pylint-1.8.2/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: jedi>=0.9.0 in /nix/store/mzaj8hm6x9szwskh1z6gmm4vcl4bz3ik-python2.7-jedi-0.11.1/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: pycodestyle in /nix/store/47fniyjczd3nacnym72mya9i4w8kinkz-python2.7-pycodestyle-2.3.1/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: psutil in /nix/store/96ral8lnx118a1qccink2z2bhsmyg7ar-python2.7-psutil-5.4.3/lib/python2.7/site-packages (from spyder==3.2.6)
Requirement already satisfied: nbconvert in /nix/store/18mqml1f4gb9ya5w2plxvkf56bds2hh1-python2.7-nbconvert-5.3.1/lib/python2.7/site-packages (from spyder==3.2.6)
Collecting pyopengl; platform_system == "Linux" (from spyder==3.2.6)
  Could not find a version that satisfies the requirement pyopengl; platform_system == "Linux" (from spyder==3.2.6) (from versions: )
No matching distribution found for pyopengl; platform_system == "Linux" (from spyder==3.2.6)
builder for ‘/nix/store/xqwzwxz29ipxvf081sxd44qpxk4bfqgs-spyder-3.2.6.drv’ failed with exit code 1
error: build of ‘/nix/store/xqwzwxz29ipxvf081sxd44qpxk4bfqgs-spyder-3.2.6.drv’ failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

                         yyParenDepth--;
                         ^~~~~~~~~~~~
g++ -c -pipe -O2 -fno-exceptions -Wall -W -D_REENTRANT -fPIC -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DPy_LIMITED_API=0x03040000 -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG -DQT_PLUGIN -DQT_XML_LIB -DQT_CORE_LIB -I. -I. -isystem /nix/store/w81d7rbysi0rmf9c47njqbxjnllqv9cq-python-2.7.14/include/python2.7 -I../qpy/pylupdate -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtXml -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtCore -I. -I/nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/mkspecs/linux-g++ -o metatranslator.o ../qpy/pylupdate/metatranslator.cpp
g++ -c -pipe -O2 -fno-exceptions -Wall -W -D_REENTRANT -fPIC -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DPy_LIMITED_API=0x03040000 -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG -DQT_PLUGIN -DQT_XML_LIB -DQT_CORE_LIB -I. -I. -isystem /nix/store/w81d7rbysi0rmf9c47njqbxjnllqv9cq-python-2.7.14/include/python2.7 -I../qpy/pylupdate -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtXml -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtCore -I. -I/nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/mkspecs/linux-g++ -o numberh.o ../qpy/pylupdate/numberh.cpp
g++ -c -pipe -O2 -fno-exceptions -Wall -W -D_REENTRANT -fPIC -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DPy_LIMITED_API=0x03040000 -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG -DQT_PLUGIN -DQT_XML_LIB -DQT_CORE_LIB -I. -I. -isystem /nix/store/w81d7rbysi0rmf9c47njqbxjnllqv9cq-python-2.7.14/include/python2.7 -I../qpy/pylupdate -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtXml -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtCore -I. -I/nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/mkspecs/linux-g++ -o proparser.o ../qpy/pylupdate/proparser.cpp
g++ -c -pipe -O2 -fno-exceptions -Wall -W -D_REENTRANT -fPIC -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DPy_LIMITED_API=0x03040000 -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG -DQT_PLUGIN -DQT_XML_LIB -DQT_CORE_LIB -I. -I. -isystem /nix/store/w81d7rbysi0rmf9c47njqbxjnllqv9cq-python-2.7.14/include/python2.7 -I../qpy/pylupdate -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtXml -isystem /nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/include/QtCore -I. -I/nix/store/ibfm5z49nv2jvdcv4wk0p5d4pp8czk4f-qtbase-5.10.0-dev/mkspecs/linux-g++ -o sametexth.o ../qpy/pylupdate/sametexth.cpp
building of ‘/nix/store/nqg1b3h2dmvp7gr9zw1mf58il85flhrc-python2.7-PyQt-5.10.drv’ timed out after 1800 seconds
cannot build derivation ‘/nix/store/lr138a8lj9x8ajhxsvd0m3z3lghniac4-python2.7-qtconsole-4.3.1.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/xqwzwxz29ipxvf081sxd44qpxk4bfqgs-spyder-3.2.6.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/xqwzwxz29ipxvf081sxd44qpxk4bfqgs-spyder-3.2.6.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

[2967/21250] CXX obj/services/service_manager/public/cpp/cpp/service_runner.o
[2968/21250] ACTION //third_party/WebKit/Source/bindings/core/v8:generate_bindings_core_v8_interfaces(/build/qtwebengine-everywhere-src-5.10.0/src/toolchain:target)
[2969/21250] CXX obj/services/service_manager/public/cpp/cpp/service.o
[2970/21250] ACTION //third_party/WebKit/Source/bindings/core/v8:bindings_core_conditional_features(/build/qtwebengine-everywhere-src-5.10.0/src/toolchain:target)
[2971/21250] CXX obj/services/service_manager/public/cpp/standalone_service/standalone_service/linux_sandbox.o
building of '/nix/store/k1zx0cqlwfyqpap7igla25vvryfq6af3-qtwebengine-5.10.0.drv' timed out after 3200 seconds
cannot build derivation '/nix/store/c9a3yajs6qidn9xv32wf539bfx673nxf-python2.7-PyQt-5.10.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/71fzqc715hcfjilnlpw8fcpjdn5fkhkb-python2.7-qtconsole-4.3.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/41fcq1sk2g0ppsvq13jls3jm5i4sqjam-spyder-3.2.6.drv': 9 dependencies couldn't be built
error: build of '/nix/store/41fcq1sk2g0ppsvq13jls3jm5i4sqjam-spyder-3.2.6.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

[4934/21250] CXX obj/third_party/icu/bundled_icui18n/regeximp.o
[4935/21250] CC obj/third_party/libvpx/bundled_libvpx/idct32x32_34_add_neon.o
[4936/21250] CC obj/third_party/ffmpeg/ffmpeg_internal/rdft.o
[4937/21250] CXX obj/third_party/libwebm/libwebm/mkvmuxer.o
[4938/21250] CC obj/third_party/ffmpeg/ffmpeg_internal/autorename_libavformat_options.o
building of '/nix/store/k1zx0cqlwfyqpap7igla25vvryfq6af3-qtwebengine-5.10.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/c9a3yajs6qidn9xv32wf539bfx673nxf-python2.7-PyQt-5.10.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/71fzqc715hcfjilnlpw8fcpjdn5fkhkb-python2.7-qtconsole-4.3.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/41fcq1sk2g0ppsvq13jls3jm5i4sqjam-spyder-3.2.6.drv': 9 dependencies couldn't be built
error: build of '/nix/store/41fcq1sk2g0ppsvq13jls3jm5i4sqjam-spyder-3.2.6.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

[4930/21250] CC obj/third_party/ffmpeg/ffmpeg_internal/flacdec.o
[4931/21250] CC obj/third_party/ffmpeg/ffmpeg_internal/id3v1.o
[4932/21250] CXX obj/third_party/icu/bundled_icuuc/uhash_us.o
[4933/21250] CC obj/third_party/ffmpeg/ffmpeg_internal/options.o
[4934/21250] CC obj/third_party/ffmpeg/ffmpeg_internal/rmsipr.o
building of '/nix/store/k1zx0cqlwfyqpap7igla25vvryfq6af3-qtwebengine-5.10.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/c9a3yajs6qidn9xv32wf539bfx673nxf-python2.7-PyQt-5.10.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/71fzqc715hcfjilnlpw8fcpjdn5fkhkb-python2.7-qtconsole-4.3.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/41fcq1sk2g0ppsvq13jls3jm5i4sqjam-spyder-3.2.6.drv': 9 dependencies couldn't be built
error: build of '/nix/store/41fcq1sk2g0ppsvq13jls3jm5i4sqjam-spyder-3.2.6.drv' failed

Note I still get
```
This application failed to start because it could not find or load the
Qt platform plugin "xcb"
in "".
```
but that may be because I run it from the store which is not support for
Qt5 applications.
@FRidh FRidh merged commit c1d7950 into staging Feb 4, 2018
@FRidh FRidh deleted the python-unstable branch February 4, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants