Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jinja2: 2.9.6 -> 2.10 #34544

Merged
merged 1 commit into from Feb 3, 2018
Merged

pythonPackages.jinja2: 2.9.6 -> 2.10 #34544

merged 1 commit into from Feb 3, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 3, 2018 •
edited

Motivation for this change

Needed for upcoming homeassistant==0.63.0 (will be released in about a week)
See home-assistant/core#12118

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc maintainers @nbp @garbas @sjourdois

@dotlambda dotlambda requested a review from FRidh as a code owner February 3, 2018 00:58
@dotlambda
Copy link
Member Author

When running nox-review, I get the error configure: error: GNAT is required to build ada. Seems to be a bootstrapping problem but neither do I know how to fix it nor do I think this is related to jinja2.

@dotlambda
Copy link
Member Author

I guess this would need to be tested in staging first? If so, I can open another PR, against staging this time.

@FRidh FRidh changed the base branch from master to staging February 3, 2018 08:49
@FRidh FRidh merged commit d2aa510 into NixOS:staging Feb 3, 2018
@dotlambda dotlambda deleted the jinja2 branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @FRidh @GrahamcOfBorg