Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_heap_text fix #3140

Merged
merged 2 commits into from Feb 4, 2018
Merged

is_heap_text fix #3140

merged 2 commits into from Feb 4, 2018

Conversation

cogle
Copy link
Contributor

@cogle cogle commented Feb 3, 2018 •
edited

Fixes #3139

@taeguk
Copy link
Member

taeguk commented Feb 3, 2018 •
edited

@cogle Oh, very thanks for your PR!
Additionally, I have two suggestions.

https://github.com/cogle/hpx/blob/142e1b36d7d512ec281d8b11019da0c27a072fd5/tests/unit/parallel/algorithms/is_heap_tests.hpp#L70-L72
First, how about removing default type for DataType?

https://github.com/cogle/hpx/blob/142e1b36d7d512ec281d8b11019da0c27a072fd5/tests/unit/parallel/algorithms/is_heap_tests.hpp#L377-L380
Second, how about applying same modifications to test_is_heap_async()?

@hkaiser hkaiser added this to the 1.1.0 milestone Feb 3, 2018
hkaiser
hkaiser approved these changes Feb 3, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch, LGTM!

@cogle
Copy link
Contributor Author

cogle commented Feb 4, 2018 •
edited

@taeguk, please look to see if the recommendations that you suggested were implemented in accordance to what you had in mind. If anything is off I would be more than happy to fix it.

taeguk
taeguk approved these changes Feb 4, 2018
View reviewed changes
Copy link
Member

@taeguk taeguk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Very thanks 👍

@hkaiser hkaiser merged commit 82acee8 into STEllAR-GROUP:master Feb 4, 2018
@hkaiser
Copy link
Member

hkaiser commented Feb 4, 2018

@cogle Congratulations on you first merged PR! Please get in contact with @aserio to discuss how to receive the deserved STE||AR-Group t-shirt.

@aserio
Copy link
Contributor

aserio commented Feb 14, 2018

Congrats @cogle on your pull request! Are you interested in receiving a STE||AR Group T-Shirt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

@taeguk taeguk taeguk approved these changes

Assignees
No one assigned
Labels
category: algorithms category: tests type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cogle @taeguk @hkaiser @aserio