Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler app: add support for man pages #34548

Closed
wants to merge 2 commits into from
Closed

bundler app: add support for man pages #34548

wants to merge 2 commits into from

Conversation

sorki
Copy link
Member

@sorki sorki commented Feb 3, 2018

Expected gem directory structure is man/manN/name.N where N is man section,
e.g. man/man1/ls.1. Then set bundlerApp.manpages = [ "man1/ls.1" ].

Motivation for this change

Support for manpages in bundlerApp projects.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sorki sorki requested a review from zimbatm as a code owner February 3, 2018 06:50
@zimbatm
Copy link
Member

zimbatm commented Feb 4, 2018

@sorki sounds good. could you also upgrade one package to it just to test it out?

@sorki
Copy link
Member Author

sorki commented Feb 17, 2018

So we're using this for out-of-tree package and the only other application in nixpkgs is bcat which uses different directory structure. Need to play with this and try to make it a bit more generic if possible.

aither64 and others added 2 commits October 27, 2018 15:42
@sorki
bundler app: add support for man pages
0b6155d 
Expected gem directory structure is man/manN/name.N where N is man section,
e.g. man/man1/ls.1. Then set bundlerApp.manpages = [ "man1/ls.1" ].
@sorki
bcat: propagate manpages
02af8a3
@sorki
Copy link
Member Author

sorki commented Oct 27, 2018

Works but do not merge yet, @manveru found a better way with find so we don't have to list these explicitely.

@zimbatm
Copy link
Member

zimbatm commented Oct 28, 2018

sounds good, ping me when it's done

@manveru manveru mentioned this pull request Oct 28, 2018
Merged
9 tasks
@zimbatm zimbatm closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sorki @zimbatm @GrahamcOfBorg @aither64