Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small documentation fix #767

Merged
merged 1 commit into from Feb 3, 2018
Merged

Small documentation fix #767

merged 1 commit into from Feb 3, 2018

Conversation

voglster
Copy link
Contributor

@voglster voglster commented Feb 2, 2018

The setting name does not match the expected name (dropped the "File") added this to docs and did not change the setting to preserve backward compatibility.

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #767 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files         100      100           
  Lines        4461     4461           
=======================================
  Hits         3128     3128           
  Misses       1333     1333
Impacted Files Coverage Δ
src/wiki/plugins/attachments/settings.py 93.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1199e...745103a. Read the comment docs.

@benjaoming benjaoming merged commit 73ac834 into django-wiki:master Feb 3, 2018
@benjaoming
Copy link
Member

Thanks for the quick fix that will be helpful for others @voglster ! True, that should have been named in a more systematic way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants