Add a containerd module #34402

vdemeester · 2018-01-29T23:53:56Z

This add a containerd module so you can have a containerd systemd service
running and using it with other tools. One possibility is to make dockerd
using this containerd service using --containerd flag on dockerd

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Have a containerd module, that could be used with dockerd or kubernetes and cri-containerd, etc..

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-01-30T09:19:28Z

the module is not included in modules/module-list.nix

vdemeester · 2018-01-30T15:47:18Z

@Mic92 oups.. I forgot to commit that 🤦‍♂️

vdemeester · 2018-02-28T16:59:51Z

ping 👼 🙏

Mic92 · 2018-03-09T19:44:00Z

nixos/modules/virtualisation/containerd.nix

+            ""
+            ''
+              ${cfg.package}/bin/containerd \
+                ${cfg.extraOptions}


somebody found that trick!

Mic92 · 2018-03-09T19:44:18Z

nixos/modules/virtualisation/containerd.nix

+
+      systemd.services.containerd = {
+        wantedBy = [ "multi-user.target" ];
+        environment = proxy_env;


Where is this option defined?

Oups, it's not supposed to be there ... 😓

vdemeester · 2018-03-11T14:29:21Z

Updated 👼

Mic92 · 2018-03-12T10:56:45Z

nixos/modules/virtualisation/containerd.nix

+
+  config = mkIf cfg.enable (mkMerge [{
+      environment.systemPackages = [ cfg.containerd ];
+      systemd.packages = [ cfg.containerd ];


This should be pkgs.containerd or cfg.package. Have you ever tested this module?

Mic92 · 2018-03-12T10:57:02Z

nixos/modules/virtualisation/containerd.nix

+          ExecStart = [
+            ""
+            ''
+              ${cfg.package}/bin/containerd \


cfg.package does not exists as well.

Mic92 · 2018-03-12T10:58:04Z

Please test modules before ticking the Tested execution of all binary files checkbox in the pull request templates.

vdemeester · 2018-03-12T11:01:46Z

@Mic92 oh.. seems like I didn't correctly update that file frol my nixos configuration, sorry 🙇, I'll update 😇

colemickens · 2018-08-07T08:30:53Z

This seems okay to merge now?

vdemeester · 2018-08-07T08:36:20Z

@colemickens I need to updated the module to be able to add some additionnal packages in the service path… This will be useful when using containerd with additionnal runtime (other than runc)

vdemeester · 2018-08-07T08:41:09Z

Updated 👼

colemickens · 2018-09-02T00:30:36Z

Ping @Mic92, can you review/merge? Thanks!

vdemeester · 2019-01-30T10:17:57Z

ping @Mic92 @nlewo

PsyanticY · 2019-07-21T10:10:09Z

ping @Mic92

JohnAZoidberg · 2019-07-21T10:54:38Z

nixos/modules/virtualisation/containerd.nix

+      default = ["/run/containerd/containerd.sock"];
+      description =
+      ''
+        A list of unix and tcp containerd should listen to. The format follows


A list of unix and tcp what? Sockets?

Suggested change

A list of unix and tcp containerd should listen to. The format follows

A list of unix and TCP sockets containerd should listen to. The format follows

nixos/modules/virtualisation/containerd.nix

JohnAZoidberg · 2019-07-21T10:56:10Z

nixos/modules/virtualisation/containerd.nix

+      description = "List of packages to be added to containerd service path";
+    };
+
+    extraOptions =


Why unnecessarily indent it?

Suggested change

extraOptions =

extraOptions = mkOption {

JohnAZoidberg · 2019-07-21T10:56:33Z

nixos/modules/virtualisation/containerd.nix

+      wantedBy = [ "multi-user.target" ];
+      serviceConfig = {
+        ExecStart = [
+          ""


What's this for?

JohnAZoidberg · 2019-07-21T10:57:05Z

nixos/modules/virtualisation/containerd.nix

+        ExecStart = [
+          ""
+        ''
+          ${pkgs.containerd}/bin/containerd \


Does it work with a multiline command? It's very short, just put it in a single line.

JohnAZoidberg · 2019-07-21T10:57:59Z

nixos/modules/virtualisation/containerd.nix

+          ${cfg.extraOptions}
+        ''];
+      };
+      path = [ pkgs.containerd ] ++ cfg.packages;


You don't need containerd in the path if you're already calling it from the absolute path.

I think it is required to get containerd-shim and some other containerd-* commands (mainly the shims)

JohnAZoidberg · 2019-07-21T10:58:48Z

nixos/modules/virtualisation/containerd.nix

+  ###### interface
+
+  options.virtualisation.containerd = {
+    enable =


Suggested change

enable =

enable = mkEnableOption "containerd";

This generates the rest.

This add a containerd module so you can have a containerd systemd service running and using it with other tools. One possibility is to make dockerd using this containerd service using `--containerd` flag on dockerd Signed-off-by: Vincent Demeester <vincent@sbr.pm>

vdemeester · 2020-05-06T07:24:43Z

@Mic92 @nlewo @JohnAZoidberg finally updated this PR 😅

stale · 2020-11-03T03:35:45Z

I marked this as stale due to inactivity. → More info

colemickens · 2020-11-03T09:55:24Z

@vdemeester did you abandon containerd or do you have this out-of-nixpkgs somewhere now?

vdemeester · 2020-11-03T10:33:27Z

@vdemeester did you abandon containerd or do you have this out-of-nixpkgs somewhere now?

I keep a module in my own configuration, but I use it less than I used to. I closed the PR because I don't find enough time right now to update it and get it merge 😅. If someone wants to take over that would be nice, otherwise, the day I find some time, I'll re-open a new one 😉

vdemeester · 2020-11-03T10:33:50Z

I can also re-open if we think it can get merged as is 😉

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jan 30, 2018

vdemeester force-pushed the add-containerd-module branch from 266f4eb to 90164e4 Compare January 30, 2018 00:32

vdemeester force-pushed the add-containerd-module branch 3 times, most recently from 367c4ff to 3f1e076 Compare January 31, 2018 00:48

Mic92 reviewed Mar 9, 2018

View reviewed changes

vdemeester force-pushed the add-containerd-module branch from 3f1e076 to 6e1c530 Compare March 11, 2018 14:29

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) labels Mar 11, 2018

Mic92 reviewed Mar 12, 2018

View reviewed changes

vdemeester force-pushed the add-containerd-module branch from 6e1c530 to ee93981 Compare March 12, 2018 16:02

vdemeester force-pushed the add-containerd-module branch from ee93981 to e2dfe8f Compare August 7, 2018 08:40

JohnAZoidberg reviewed Jul 21, 2019

View reviewed changes

vdemeester force-pushed the add-containerd-module branch from e2dfe8f to a5176c3 Compare May 6, 2020 07:19

vdemeester force-pushed the add-containerd-module branch from a5176c3 to b7796ab Compare May 6, 2020 07:23

ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 labels May 6, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 3, 2020

vdemeester closed this Nov 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a containerd module #34402

Add a containerd module #34402

vdemeester commented Jan 29, 2018 •

edited

Mic92 commented Jan 30, 2018

vdemeester commented Jan 30, 2018

vdemeester commented Feb 28, 2018

Mic92 Mar 9, 2018

vdemeester Mar 11, 2018

Mic92 Mar 9, 2018

vdemeester Mar 11, 2018

vdemeester commented Mar 11, 2018

Mic92 Mar 12, 2018

Mic92 Mar 12, 2018

Mic92 commented Mar 12, 2018 •

edited

vdemeester commented Mar 12, 2018

colemickens commented Aug 7, 2018

vdemeester commented Aug 7, 2018

vdemeester commented Aug 7, 2018

colemickens commented Sep 2, 2018

vdemeester commented Jan 30, 2019

PsyanticY commented Jul 21, 2019

JohnAZoidberg Jul 21, 2019

JohnAZoidberg Jul 21, 2019

JohnAZoidberg Jul 21, 2019

JohnAZoidberg Jul 21, 2019

JohnAZoidberg Jul 21, 2019

vdemeester May 6, 2020

JohnAZoidberg Jul 21, 2019

vdemeester commented May 6, 2020

stale bot commented Nov 3, 2020

colemickens commented Nov 3, 2020

vdemeester commented Nov 3, 2020

vdemeester commented Nov 3, 2020

	A list of unix and tcp containerd should listen to. The format follows
	A list of unix and TCP sockets containerd should listen to. The format follows

Navigation Menu

Add a containerd module #34402

Add a containerd module #34402

Conversation

vdemeester commented Jan 29, 2018 • edited

Motivation for this change

Things done

Mic92 commented Jan 30, 2018

vdemeester commented Jan 30, 2018

vdemeester commented Feb 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vdemeester commented Mar 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 commented Mar 12, 2018 • edited

vdemeester commented Mar 12, 2018

colemickens commented Aug 7, 2018

vdemeester commented Aug 7, 2018

vdemeester commented Aug 7, 2018

colemickens commented Sep 2, 2018

vdemeester commented Jan 30, 2019

PsyanticY commented Jul 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vdemeester commented May 6, 2020

stale bot commented Nov 3, 2020

colemickens commented Nov 3, 2020

vdemeester commented Nov 3, 2020

vdemeester commented Nov 3, 2020

vdemeester commented Jan 29, 2018 •

edited

Mic92 commented Mar 12, 2018 •

edited