Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix: Correct license #34414

Merged
merged 1 commit into from Feb 1, 2018
Merged

postfix: Correct license #34414

merged 1 commit into from Feb 1, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 30, 2018 •
edited

Motivation for this change

The postfix derivation incorrectly lists BSD as the license, whereas postfix up to version 3.2.4 is licensed under IBM Public License 1.0. Maybe this should also be corrected in the 17.09 branch.
According to http://www.postfix.org/announcements/postfix-3.2.5.html,

starting with Postfix 3.2.5, Postfix 3.2 is distributed with a dual license: in addition to the historical IBM Public License 1.0, it is now also distributed with the more recent Eclipse Public License 2.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc maintainer @rickynils

@dotlambda
Copy link
Member Author

/cc @adisbladis

@dotlambda
Copy link
Member Author

/cc @fpletz

fpletz
fpletz approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! We should probably bump postfix in 17.09 anyway because these are bugfix releases.

@dotlambda
Copy link
Member Author

Created a PR for 17.09 in #34479

@fpletz fpletz merged commit c788586 into NixOS:master Feb 1, 2018
@dotlambda dotlambda deleted the postfix branch February 1, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @fpletz @GrahamcOfBorg