lib: Better use the module type system in platform parsing #34400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
commented
Jan 29, 2018
|
|
||
| types.significantByte = enum (attrValues significantBytes); | ||
|
|
||
| significantBytes = setTypes types.openSignifiantByte { |
There was a problem hiding this comment.
Hmm I supposed unlike the other {} whitelists, I'll never add a third endianness, so this can just be a [ "bigEndian" "littleEndian" ] enum?
Mic92
reviewed
Jan 30, 2018
lib/systems/parse.nix
Outdated
|
|
||
| types.openExecFormat = mkOptionType { | ||
| name = "exec-format"; | ||
| description = "executble container used by the kernel"; |
I need some module system types here so I can next fix meta-checks for derivations. I'd like to use a "proper" record type here, but submodule types seem overkill so holding off with ad-hoc stuff for now. In practice, all I need for the next step are the `.check` functions so this is good, especially as the submodule check function is shallow, saving full inductive type-checking for a later step.
Ericson2314
force-pushed
the
meta-check
branch
from
7b558c8
to
c505784
Compare
|
I'm going to merge this now so I can do the next bit. @nbp I hope you eventually have time to look at this, but at least nothing I do next will constrain much what's here so it won't be too late whenever you do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I need some module system types here so I can next fix meta-checks for derivations. I'd like to use a "proper" record type here, but submodule types seem overkill so holding off with ad-hoc stuff for now. In practice, all I need for the next step are the
.checkfunctions so this is good, especially as the submodule check function is shallow, saving full inductive type-checking for a later step.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)CC @ElvishJerricco @danharaj