{llvm,clang}-{4,5}: don't rebuild entire projects just to get manpages #33948
Conversation
|
:-) EDIT: it probably doesn't much matter, as people aren't likely to use it without llvm itself... |
Much cheaper to build this way. Also this gives them a different name to avoid confusion and clutter when using `nix-env -qaP` or similar.
dtzWill
force-pushed
the
feature/llvm-manpages-slim
branch
from
fa63a42 to
514f67e
Compare
|
@vcunat haha whoops, fixed! |
| @@ -20,7 +20,7 @@ let | |||
| # Add man output without introducing extra dependencies. | |||
| overrideManOutput = drv: | |||
| let drv-manpages = drv.override { enableManpages = true; }; in | |||
| drv // { man = drv-manpages.man; /*outputs = drv.outputs ++ ["man"];*/ }; | |||
| drv // { man = drv-manpages.out; /*outputs = drv.outputs ++ ["man"];*/ }; | |||
There was a problem hiding this comment.
It's less painful, as the pages are relatively cheap to build. I suppose it can be useful for uniformity (e.g. programs.man.enable in configuration.nix).
There was a problem hiding this comment.
I believe so, unfortunately :P. While this makes the manpages much cheaper to build and have a tiny runtime closure, the build-time dependencies are still numerous but most problematically is that they include things like Sphinx (python package) that shouldn't force Darwin rebuilds.
There was a problem hiding this comment.
BTW, the build-time closure of man pages could be cut down, somewhat, but probably not too much.
|
Ping! |
|
Please rebase to resolve conflicts. |
orivej
added
the
2.status: merge conflict
|
The conflict was trivial (syntactic). |
Don't rebuild entire projects just to get manpages.
#33369 (comment)
Also give manpage derivations different names so that they
don't clutter up
nix-env -qaPand such.Doesn't change hash for current llvm/clang-unwrapped,
hopefully avoids mass-rebuild on Darwin.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)