Local execution of direct actions is now actually performed directly #3104
Conversation
| this_thread::get_stack_size() == | ||
| threads::get_stack_size( | ||
| static_cast<threads::thread_stacksize>( | ||
| traits::action_stacksize<Action>::value)); |
There was a problem hiding this comment.
I suggest to rather change it to
return !traits::action_decorate_function<Action>::value &&
this_thread::get_stack_size() >=
threads::get_stack_size(
static_cast<threads::thread_stacksize>(
traits::action_stacksize<Action>::value));
That way, we don't run into the problem if an action should run on a larger stack than what we have currently.
The priority change is correct though, as we intend to run the action immediately anyway.
There was a problem hiding this comment.
The problem with not checking the priority is that the following test fails then:
http://cdash.cscs.ch/testDetails.php?test=11627793&build=73031
For the stacksize, we get this failure:
http://cdash.cscs.ch/testDetails.php?test=11628196&build=73031
There was a problem hiding this comment.
Checking the priority does not make any sense as the function will be executed right away. I'd suggest correcting the test. I agree on the stack size change you suggested, though. That should also make the test pass.
There was a problem hiding this comment.
The tests don't use direct actions. The actions are just executed locally.
There was a problem hiding this comment.
Sure, I didn't say anything about direct actions, though. I still think that the tests are overly constrained.
There was a problem hiding this comment.
@sithhell Your comments have been addressed.
hkaiser
force-pushed
the
fixing_local_direct_actions
branch
3 times, most recently
from
14be494
to
1ebb3a3
Compare
- flyby: expose has_decorates_action as a first class trait in namespace hpx::traits
hkaiser
force-pushed
the
fixing_local_direct_actions
branch
from
1ebb3a3
to
6706984
Compare
- this was exposed by the recent patch fixing direct execution (#3104)
… execution) - this was exposed by the recent patch fixing direct execution (#3104) - flyby: don't run channel_2916 as a distributed test
… execution) - this was exposed by the recent patch fixing direct execution (#3104) - flyby: don't run channel_2916 as a distributed test
… execution) - this was exposed by the recent patch fixing direct execution (#3104) - flyby: don't run channel_2916 as a distributed test
Proposed Changes