Fix virtualType for network-interfaces-scripted #34442
Merged
+60
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
10.rebuild-darwin: 0
Mic92
reviewed
Feb 1, 2018
| "The list of virtual interfaces does not match the expected one:\n", | ||
| "Result:\n", "$list\n", | ||
| "Expected:\n", "$targetList\n" | ||
| ); |
There was a problem hiding this comment.
I would simplify the check to not depend on the output of ip:
$machine->succeed("ip link show tap0");
$machine->succeed("ip link show tun0");
There was a problem hiding this comment.
This ways it also checks the type and owner of the interface are set correctly.
|
@GrahamcOfBorg test tests.networking.scripted.virtual |
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg test networking.scripted.virtual |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Woops, I forgot to squash the last commit. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix bug in #34258 and add a test ot prevent it
Things done
nixos/tests/networking.nix