sacad: init at 2.0.6 #34458
sacad: init at 2.0.6 #34458
Conversation
web_cache: init at 1.0.2
| sha256 = "05mmxf5f312mi9g417zad20f8v76wjm36b0v75x96diffccaafp0"; | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why are the tests disabled? Please include a comment.
pkgs/tools/misc/sacad/default.nix
Outdated
| @@ -0,0 +1,37 @@ | |||
| { pkgs, jpegoptim, optipng }: | |||
There was a problem hiding this comment.
Don't pass in the whole package set. Instead, pass in the exact dependencies.
There was a problem hiding this comment.
In case of Python and its packages, you can pass in python3.
pkgs/tools/misc/sacad/default.nix
Outdated
| @@ -0,0 +1,37 @@ | |||
| { pkgs, jpegoptim, optipng }: | |||
|
|
|||
| let | |||
pkgs/tools/misc/sacad/default.nix
Outdated
| sha256 = "1vb2y18lmsm742pwff9164plbji3vjmx06accc84vws1nv7d1rzg"; | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why are the tests disabled? Please include a comment.
|
I introduced a failure in the evaluator today, sorry about that. Testing for a fix: @GrahamcOfBorg eval |
| buildPythonPackage rec { | ||
| pname = "web_cache"; | ||
| version = "1.0.2"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
The name attribute is added by buildPython* and should therefore be removed.
| sha256 = "05mmxf5f312mi9g417zad20f8v76wjm36b0v75x96diffccaafp0"; | ||
| }; | ||
|
|
||
| # ModuleNotFoundError: No module named 'tests' |
There was a problem hiding this comment.
That's because it's not included in the tarball. Can you replace this with
# No tests in archive
|
|
||
| with python3.pkgs; | ||
| let | ||
| inherit (python3.pkgs) buildPythonApplication fetchPypi; |
There was a problem hiding this comment.
because you have with python3.pkgs above here this line is not needed.
| buildPythonApplication rec { | ||
| pname = "sacad"; | ||
| version = "2.0.6"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
The name attribute is added by buildPython* and should therefore be removed.
| sha256 = "1vb2y18lmsm742pwff9164plbji3vjmx06accc84vws1nv7d1rzg"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = with python3.pkgs; [ |
|
@ayyjayess any interest in continuing with this PR? |
SACAD is a multi platform command line tool to download album covers without manual intervention, ideal for integration in scripts, audio players, etc.
Also includes: web_cache: init at 1.0.2
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)