Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.09] 57.0.4 -> 58.0.1 #34437

Merged
merged 4 commits into from Jan 31, 2018
Merged

[17.09] 57.0.4 -> 58.0.1 #34437

merged 4 commits into from Jan 31, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jan 31, 2018 •
edited

Motivation for this change

This is a pretty simple port of #34436. Probably needs some polishing and some of the lib changes might need to be moved into separated derivations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
firefox: 57.0.4 -> 58.0.1
ec89da7 
(cherry picked from commit 495e2b0)
@andir andir merged commit b373959 into NixOS:release-17.09 Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg