Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 58.0 -> 58.0.1 [Critical security fix] #34438

Closed
wants to merge 1 commit into from
Closed

firefox-bin: 58.0 -> 58.0.1 [Critical security fix] #34438

wants to merge 1 commit into from

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 31, 2018

Motivation for this change
  • Critical security fix

https://www.mozilla.org/en-US/firefox/58.0.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2018-05/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Jan 31, 2018

This has already been bumped in #34436. Thank you anyway. We need more people walking around with open eyes 👍

I'll close this. Feel free to open if you think there is still something missing.

@andir andir closed this Jan 31, 2018
@taku0
Copy link
Contributor Author

taku0 commented Jan 31, 2018

@andir #34436 is an update for firefox package while this is for firefox-bin package. I have no privilege to reopen PR. Please reopen this, or simply merge this PR.

@tokudan
Copy link
Contributor

tokudan commented Jan 31, 2018 •
edited

Already done for firefox-bin in #34425 for release-17.09 and #34424 for master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @andir @tokudan @GrahamcOfBorg