llvm 6: init #34457

dtzWill · 2018-01-31T14:22:00Z

Motivation for this change

Start building and testing LLVM 6, currently on RC1.

Helps ensure release doesn't have bugs re:NixOS / our projects, and hopefully enables us to at least make LLVM 6 available after final release and update the default shortly after.

Anyway, test test please! :)

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

grahamc · 2018-01-31T19:51:09Z

I introduced a failure in the evaluator today, sorry about that. Testing for a fix:

@GrahamcOfBorg eval

dtzWill · 2018-02-01T06:18:26Z

@GrahamcOfBorg build clang_6 lld_6 lldb_6

GrahamcOfBorg · 2018-02-01T06:18:54Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file lib/Support/Unix/Memory.inc.rej
builder for '/nix/store/i92fqldk238rl07g26bkjqxvkv94fra8-llvm-6.0.0rc1.drv' failed with exit code 1
cannot build derivation '/nix/store/b5jrr1h8b46ygimw9lp4drcnxn87hw8h-clang-6.0.0rc1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/irx1p6ad17rd4lnjzipyxk3m1d8209fm-clang-manpages-6.0.0rc1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y1a9xzcngy03br51sbprglql0i5nb8ly-lld-6.0.0rc1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6gz68lw4cxn3hdn07rx5k7darl2xw61p-clang-wrapper-6.0.0rc1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/8r11d5hv3rqxv17038nj2fwkhw9n8wqx-lldb-6.0.0rc1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/6gz68lw4cxn3hdn07rx5k7darl2xw61p-clang-wrapper-6.0.0rc1.drv', '/nix/store/8r11d5hv3rqxv17038nj2fwkhw9n8wqx-lldb-6.0.0rc1.drv', '/nix/store/y1a9xzcngy03br51sbprglql0i5nb8ly-lld-6.0.0rc1.drv' failed

GrahamcOfBorg · 2018-02-01T06:49:26Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

[ 19%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InstructionSimplify.cpp.o
[ 19%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/Interval.cpp.o
[ 19%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/IntervalPartition.cpp.o
building of '/nix/store/6sxf163jcv8cam64iv64dj0pc5jhz0g3-llvm-6.0.0rc1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/pkkf8vz9gxjbd064w8jz3z5mhc5zx2y0-clang-6.0.0rc1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/66swviph1yyx87n8kp0wg43d2s105lyj-clang-manpages-6.0.0rc1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x3i2pb5vn93bc3alvj5rg6vhavpi5l8g-lld-6.0.0rc1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1dfaybl6hm8p12mqbids4lz6aqbivg42-clang-wrapper-6.0.0rc1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nkx8mn730kg13wx16vqf7wfp13javjwg-lldb-6.0.0rc1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/1dfaybl6hm8p12mqbids4lz6aqbivg42-clang-wrapper-6.0.0rc1.drv', '/nix/store/nkx8mn730kg13wx16vqf7wfp13javjwg-lldb-6.0.0rc1.drv', '/nix/store/x3i2pb5vn93bc3alvj5rg6vhavpi5l8g-lld-6.0.0rc1.drv' failed

GrahamcOfBorg · 2018-02-01T07:18:51Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

[ 40%] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULibCalls.cpp.o
[ 40%] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULibFunc.cpp.o
[ 40%] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULowerIntrinsics.cpp.o
building of ‘/nix/store/03ikphp5a22crk0m6vmy231ydwy8qpq1-llvm-6.0.0rc1.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/4w3r4s8s4yy93sd3745yy68xzx0n3h83-clang-6.0.0rc1.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/77h0vadd54g207r22m5rjzqaapvsgbg4-clang-manpages-6.0.0rc1.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/aaarl8abw7dz2lpj193wamv6s9hz16kg-lld-6.0.0rc1.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/4cigd5f184c80nr3sdq7fyzfh383xk7v-clang-wrapper-6.0.0rc1.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/3w8gb4v5bia2wlg4c037cimk1lmssiyk-lldb-6.0.0rc1.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/3w8gb4v5bia2wlg4c037cimk1lmssiyk-lldb-6.0.0rc1.drv’, ‘/nix/store/4cigd5f184c80nr3sdq7fyzfh383xk7v-clang-wrapper-6.0.0rc1.drv’, ‘/nix/store/aaarl8abw7dz2lpj193wamv6s9hz16kg-lld-6.0.0rc1.drv’ failed

LnL7

Everything builds on darwin.

LnL7 · 2018-02-01T18:07:28Z

pkgs/development/compilers/llvm/6/llvm.nix

+    mv compiler-rt-* $sourceRoot/projects/compiler-rt
+  '';
+
+  outputs = [ "out" ]


Does this need something similar to #33871 to get python out of the closure?

Good call. Added.

LnL7 · 2018-02-01T18:07:45Z

pkgs/top-level/all-packages.nix


  llvm = llvmPackages.llvm;

+  llvm_6  = llvmPackages_6.llvm;


Should we keep exposing all of these top-level?

LnL7 · 2018-02-01T18:11:09Z

pkgs/development/compilers/llvm/6/llvm.nix

+in stdenv.mkDerivation (rec {
+  name = "llvm-${version}";
+
+  unpackPhase = ''


I cleaned this up on a test branch recently, let me see if I can find it.

These all need to be refactored, was thinking of starting with refactoring 5 and 6 (possibly 4 and earlier) since they especially are so similar.

Soon (tm)!

EDIT: err, but that's not to say cleanup would be very welcome in the meantime! 👍

dtzWill · 2018-02-08T22:26:05Z

rc2 has been tagged, but appears they don't upload the source tarballs until the "release testers" all build and upload binaries, so should be available in a few days. Not worth bothering with grabbing off of SVN in the meantime, IMO.

dtzWill · 2018-02-13T20:38:27Z

rc2 has been out for a bit, but I haven't gotten to updating this yet, sorry!

LnL7 · 2018-02-13T20:44:11Z

I don't think this is urgent since the build works.

dtzWill · 2018-02-19T19:48:54Z

rebased and fixed merge conflicts. Added testing variants like we have for other versions.

Will be adding musl compat fixes too, now that they're in master as well 👍.

dtzWill · 2018-02-19T20:01:47Z

Postponing musl fixes here while resolving discussion about musl ...

EDIT: nevermind, useful enough for my own purposes to justify :D.

dtzWill · 2018-02-26T19:59:51Z

rebased, rc2 -> rc3 \o/

dtzWill · 2018-03-02T23:31:59Z

Hold on to your lugnuts! LLVM 6 final has been tagged:

http://lists.llvm.org/pipermail/release-testers/2018-March/000667.html

Will be a few more days for them to prepare the release and official source tarballs but .... soon!!

LnL7 · 2018-03-03T09:43:48Z

Great!

Unlike that PR, however, this doesn't need to go to staging since no one depends on a package that doesn't exist yet :).

dtzWill · 2018-03-08T18:18:31Z

Release notes: http://releases.llvm.org/6.0.0/docs/ReleaseNotes.html

Note this adds support for "retpolines", which may be of interest to those using clang-based stdenv's.

llvm 6: init (cherry picked from commit b09b557)

data-man · 2018-03-09T15:52:35Z

Sorry, but how do I use the clang 6?
I just started using the NixOS.

dtzWill · 2018-03-09T20:11:53Z

I don't think it's hit any channels yet, so in the meantime you can use something like this:

$ NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/master.tar.gz nix-shell -p clang_6

and use clang within that shell. Note that "installing" clang generally doesn't work as you may expect, there's an issue discussing this.

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 31, 2018

LnL7 reviewed Feb 1, 2018

View reviewed changes

dtzWill force-pushed the feature/llvm-6 branch from 8dafcfc to 585652b Compare February 2, 2018 12:40

dtzWill force-pushed the feature/llvm-6 branch from 585652b to da39e61 Compare February 14, 2018 17:07

GrahamcOfBorg added the 8.has: package (new) label Feb 14, 2018

dtzWill force-pushed the feature/llvm-6 branch from da39e61 to 3e4e2cf Compare February 19, 2018 19:43

dtzWill force-pushed the feature/llvm-6 branch 2 times, most recently from 81f3746 to 2554496 Compare February 26, 2018 19:59

dtzWill force-pushed the feature/llvm-6 branch from 2554496 to 14fa76b Compare March 2, 2018 01:09

dtzWill added 7 commits March 7, 2018 19:03

llvm6: copy llvm5

4463de6

llvm6: rc1, hashes, top-level

42c3a74

lld: Add dep on libxml2

a192c9d

llvm6: no need to patch on aarch64, already applied

0d90539

llvm6: same python output fix from NixOS#33871

11cb7d0

Unlike that PR, however, this doesn't need to go to staging since no one depends on a package that doesn't exist yet :).

llvm6: rc1 -> rc2

62011cf

clang-6 test variants

ab0a72a

dtzWill added 4 commits March 7, 2018 19:03

llvm6: musl compat

e876e97

llvm6: drop perl and groff, as in llvm4/5

c3e16a4

llvm6: remove copied "remove this on next rebuild" value :)

9306e2f

llvm6: rc2 -> rc3

08db02e

dtzWill force-pushed the feature/llvm-6 branch from 14fa76b to 08db02e Compare March 8, 2018 01:10

llvm6: rc3 -> final

b36ea92

dtzWill changed the title ~~[WIP] llvm 6~~ llvm 6: init Mar 8, 2018

dtzWill merged commit b09b557 into NixOS:master Mar 8, 2018

dtzWill deleted the feature/llvm-6 branch March 8, 2018 18:41

dtzWill added a commit that referenced this pull request Mar 8, 2018

Merge pull request #34457 from dtzWill/feature/llvm-6

43dd25e

llvm 6: init (cherry picked from commit b09b557)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

llvm 6: init #34457

llvm 6: init #34457

dtzWill commented Jan 31, 2018 •

edited

grahamc commented Jan 31, 2018

dtzWill commented Feb 1, 2018

GrahamcOfBorg commented Feb 1, 2018

GrahamcOfBorg commented Feb 1, 2018

GrahamcOfBorg commented Feb 1, 2018

LnL7 left a comment

LnL7 Feb 1, 2018

dtzWill Feb 2, 2018

LnL7 Feb 1, 2018

LnL7 Feb 1, 2018

dtzWill Feb 2, 2018 •

edited

dtzWill commented Feb 8, 2018

dtzWill commented Feb 13, 2018

LnL7 commented Feb 13, 2018

dtzWill commented Feb 19, 2018

dtzWill commented Feb 19, 2018 •

edited

dtzWill commented Feb 26, 2018

dtzWill commented Mar 2, 2018

LnL7 commented Mar 3, 2018

dtzWill commented Mar 8, 2018

data-man commented Mar 9, 2018

dtzWill commented Mar 9, 2018

llvm 6: init #34457

llvm 6: init #34457

Conversation

dtzWill commented Jan 31, 2018 • edited

Motivation for this change

Things done

grahamc commented Jan 31, 2018

dtzWill commented Feb 1, 2018

GrahamcOfBorg commented Feb 1, 2018

GrahamcOfBorg commented Feb 1, 2018

GrahamcOfBorg commented Feb 1, 2018

LnL7 left a comment

Choose a reason for hiding this comment

LnL7 Feb 1, 2018

Choose a reason for hiding this comment

dtzWill Feb 2, 2018

Choose a reason for hiding this comment

LnL7 Feb 1, 2018

Choose a reason for hiding this comment

LnL7 Feb 1, 2018

Choose a reason for hiding this comment

dtzWill Feb 2, 2018 • edited

Choose a reason for hiding this comment

dtzWill commented Feb 8, 2018

dtzWill commented Feb 13, 2018

LnL7 commented Feb 13, 2018

dtzWill commented Feb 19, 2018

dtzWill commented Feb 19, 2018 • edited

dtzWill commented Feb 26, 2018

dtzWill commented Mar 2, 2018

LnL7 commented Mar 3, 2018

dtzWill commented Mar 8, 2018

data-man commented Mar 9, 2018

dtzWill commented Mar 9, 2018

dtzWill commented Jan 31, 2018 •

edited

dtzWill Feb 2, 2018 •

edited

dtzWill commented Feb 19, 2018 •

edited