addPassthru: fix argument order #34245
Conversation
addPassthru became unused in NixOS#33057, but its signature was changed at the same time. This commit restores the original signature and updates the warning and the changelog.
|
Hey, thanks for doing this. The documentation change is definitely a big plus. I do think it makes sense to flip the order back to what it was. There's a slim possibility that somebody has fixed a build by updating their calls to the new order, and that we'll just be breaking it for them again by flipping it back. But since the deprecation warning was there, I doubt anyone did this - anyone who was affected by this is probably using |
|
I'd like to raise another issue, although I don't want it to hold up merging this: The todo comment says that |
|
Right. I was focusing too much of the last part of the long-running PR. I would think that a few months is enough to adapt; it's not a function I'd expect to be used often. When you switch from one stable to another and get a weird error, I'd expect you to look into the incompatible changes section of release notes. (Well, I'd personally do that even before attempting the switch, if it was a production-class system.) |
Motivation for this change
addPassthrubecame unused in #33057, but its signature was changed at the same time. @chris-martin has informed us at https://groups.google.com/forum/#!topic/nix-devel/YhIRYR7W5wM that this does not make sense.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)