Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket streams can't be for_fd with real fileno #5008

Open
headius opened this issue Jan 24, 2018 · 0 comments
Open

Socket streams can't be for_fd with real fileno #5008

headius opened this issue Jan 24, 2018 · 0 comments

Comments

@headius
Copy link
Member

headius commented Jan 24, 2018

In #4858 I implemented close_on_exec logic, but the original script continued to fail because our TCPServer.for_fd (and all other JDK-based sockets) is not fully functional. Specifically, it can't reconstitute a JDK wrapper object around a real fileno, so the child fails to produce a working TCPServer socket.

IO.for_fd produces a working IO, but none of the socket methods are defined on it.

This will not be possible to fix until all socket IO is done via native streams. This would be (I believe) the last major stream type to move to fully-native IO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant