Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git to source tarball buildInputs #1814

Closed
wants to merge 1 commit into from
Closed

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 25, 2018

Fixes

$ nix build binaryTarball.x86_64-linux -f release.nix
builder for
'/nix/store/kmybvm9zzd3wyxwdklmxqwnbf88zagfg-nix-tarball-1.12pre5779_cd74a55.drv'
failed with exit code 2; last 10 log lines:
    INST   /build/tmp_prefix/share/man/man1/nix-copy-closure.1
    MKDIR  /build/tmp_prefix/share/man/man5/
    INST   /build/tmp_prefix/share/man/man5/nix.conf.5
    MKDIR  /build/tmp_prefix/share/man/man8/
    INST   /build/tmp_prefix/share/man/man8/nix-daemon.8
  /bin/sh: git: command not found
    GEN    src/libstore/schema.sql.gen.hh
    GEN    nix.spec
  make: *** No rule to make target 'src/nlohmann/json.hpp', needed by
'nix-1.12pre5779_cd74a55.tar.bz2'.  Stop.
  build time elapsed:  0m0.267s 0m0.476s 0m19.914s 0m7.074s
cannot build derivation
'/nix/store/5fv03zrnipjn07kqlzccjncjv552r319-nix-1.12pre5779_cd74a55.drv':
1 dependencies couldn't be built
cannot build derivation
'/nix/store/hlip12bv0byrwcwfh22ss03vgm9iyps3-nix-binary-tarball-1.12pre5779_cd74a55.drv':
1 dependencies couldn't be built
[0 built (1 failed), 17 copied (22.5 MiB), 13.2 MiB DL]
error: build of
'/nix/store/hlip12bv0byrwcwfh22ss03vgm9iyps3-nix-binary-tarball-1.12pre5779_cd74a55.drv'
failed

Fixes

```
$ nix build binaryTarball.x86_64-linux -f release.nix
builder for
'/nix/store/kmybvm9zzd3wyxwdklmxqwnbf88zagfg-nix-tarball-1.12pre5779_cd74a55.drv'
failed with exit code 2; last 10 log lines:
    INST   /build/tmp_prefix/share/man/man1/nix-copy-closure.1
    MKDIR  /build/tmp_prefix/share/man/man5/
    INST   /build/tmp_prefix/share/man/man5/nix.conf.5
    MKDIR  /build/tmp_prefix/share/man/man8/
    INST   /build/tmp_prefix/share/man/man8/nix-daemon.8
  /bin/sh: git: command not found
    GEN    src/libstore/schema.sql.gen.hh
    GEN    nix.spec
  make: *** No rule to make target 'src/nlohmann/json.hpp', needed by
'nix-1.12pre5779_cd74a55.tar.bz2'.  Stop.
  build time elapsed:  0m0.267s 0m0.476s 0m19.914s 0m7.074s
cannot build derivation
'/nix/store/5fv03zrnipjn07kqlzccjncjv552r319-nix-1.12pre5779_cd74a55.drv':
1 dependencies couldn't be built
cannot build derivation
'/nix/store/hlip12bv0byrwcwfh22ss03vgm9iyps3-nix-binary-tarball-1.12pre5779_cd74a55.drv':
1 dependencies couldn't be built
[0 built (1 failed), 17 copied (22.5 MiB), 13.2 MiB DL]
error: build of
'/nix/store/hlip12bv0byrwcwfh22ss03vgm9iyps3-nix-binary-tarball-1.12pre5779_cd74a55.drv'
failed
```
@edolstra
Copy link
Member

I don't think it's desirable to make git (or for that matter mercurial) a mandatory dependency.

@FRidh
Copy link
Member Author

FRidh commented Jan 25, 2018

So it can be considered a bug that git is needed to build the source tarball?

@FRidh
Copy link
Member Author

FRidh commented Jan 26, 2018

git is needed (when 1.12 is used) because of #1789

@FRidh
Copy link
Member Author

FRidh commented Jan 26, 2018

See also #1789 (comment).

@FRidh FRidh closed this Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants