Semi-silently ignore close_on_exec= on Windows for now.

headius · headius · commit 2cb38f379f2c · 2018-01-24T16:09:31.000-06:00
Fixes #4910.
diff --git a/core/src/main/java/org/jruby/RubyIO.java b/core/src/main/java/org/jruby/RubyIO.java
@@ -2185,8 +2185,8 @@ public IRubyObject close_on_exec_set(ThreadContext context, IRubyObject arg) {
         int fd = -1;
 
         if (fptr == null || (fd = fptr.fd().realFileno) == -1
-                || !posix.isNative()) {
-            runtime.getWarnings().warning("close_on_exec is not implemented for this stream type: " + fptr.fd().ch.getClass().getSimpleName());
+                || !posix.isNative() || Platform.IS_WINDOWS ) {
+            runtime.getWarnings().warning("close_on_exec is not implemented on this platform for this stream type: " + fptr.fd().ch.getClass().getSimpleName());
             return context.nil;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -2185,8 +2185,8 @@ public IRubyObject close_on_exec_set(ThreadContext context, IRubyObject arg) {`
`2185`	`2185`	`int fd = -1;`
`2186`	`2186`
`2187`	`2187`	`if (fptr == null \|\| (fd = fptr.fd().realFileno) == -1`
`2188`		`- \|\| !posix.isNative()) {`
`2189`		`- runtime.getWarnings().warning("close_on_exec is not implemented for this stream type: " + fptr.fd().ch.getClass().getSimpleName());`
	`2188`	`+ \|\| !posix.isNative() \|\| Platform.IS_WINDOWS ) {`
	`2189`	`+ runtime.getWarnings().warning("close_on_exec is not implemented on this platform for this stream type: " + fptr.fd().ch.getClass().getSimpleName());`
`2190`	`2190`	`return context.nil;`
`2191`	`2191`	`}`
`2192`	`2192`