Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This command upgrades Nix to the latest stable version by installing a store path obtained from https://github.com/NixOS/nixpkgs/raw/master/nixos/modules/installer/tools/nix-fallback-paths.nix which is the same store path that the installer at https://nixos.org/nix/install.sh uses. The upgrade fails if Nix is not installed in a profile (e.g. on NixOS, or when installed outside of the Nix store).
- Loading branch information
Showing
4 changed files
with
142 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ | |
|
||
namespace nix { | ||
|
||
extern std::string programPath; | ||
|
||
struct Value; | ||
class Bindings; | ||
class EvalState; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
#include "command.hh" | ||
#include "store-api.hh" | ||
#include "download.hh" | ||
#include "eval.hh" | ||
#include "attr-path.hh" | ||
|
||
using namespace nix; | ||
|
||
struct CmdUpgradeNix : StoreCommand | ||
{ | ||
Path profileDir; | ||
|
||
CmdUpgradeNix() | ||
{ | ||
mkFlag() | ||
.longName("profile") | ||
.shortName('p') | ||
.labels({"profile-dir"}) | ||
.description("the Nix profile to upgrade") | ||
.dest(&profileDir); | ||
} | ||
|
||
std::string name() override | ||
{ | ||
return "upgrade-nix"; | ||
} | ||
|
||
std::string description() override | ||
{ | ||
return "upgrade Nix to the latest stable version"; | ||
} | ||
|
||
Examples examples() override | ||
{ | ||
return { | ||
Example{ | ||
"To upgrade Nix to the latest stable version:", | ||
"nix upgrade-nix" | ||
}, | ||
Example{ | ||
"To upgrade Nix in a specific profile:", | ||
"nix upgrade-nix -p /nix/var/nix/profiles/per-user/alice/profile" | ||
}, | ||
}; | ||
} | ||
|
||
void run(ref<Store> store) override | ||
{ | ||
settings.pureEval = true; | ||
|
||
if (profileDir == "") | ||
profileDir = getProfileDir(store); | ||
|
||
printInfo("upgrading Nix in profile '%s'", profileDir); | ||
|
||
Path storePath; | ||
{ | ||
Activity act(*logger, lvlInfo, actUnknown, "querying latest Nix version"); | ||
storePath = getLatestNix(store); | ||
} | ||
|
||
{ | ||
Activity act(*logger, lvlInfo, actUnknown, fmt("downloading '%s'...", storePath)); | ||
store->ensurePath(storePath); | ||
} | ||
|
||
{ | ||
Activity act(*logger, lvlInfo, actUnknown, fmt("verifying that '%s' works...", storePath)); | ||
auto program = storePath + "/bin/nix-env"; | ||
auto s = runProgram(program, false, {"--version"}); | ||
if (s.find("Nix") == std::string::npos) | ||
throw Error("could not verify that '%s' works", program); | ||
} | ||
|
||
{ | ||
Activity act(*logger, lvlInfo, actUnknown, fmt("installing '%s' into profile '%s'...", storePath, profileDir)); | ||
runProgram(settings.nixBinDir + "/nix-env", false, | ||
{"--profile", profileDir, "-i", storePath, "--no-sandbox"}); | ||
} | ||
} | ||
|
||
/* Return the profile in which Nix is installed. */ | ||
Path getProfileDir(ref<Store> store) | ||
{ | ||
Path where; | ||
|
||
for (auto & dir : tokenizeString<Strings>(getEnv("PATH"), ":")) | ||
if (pathExists(dir + "/nix-env")) { | ||
where = dir; | ||
break; | ||
} | ||
|
||
if (where == "") | ||
throw Error("couldn't figure out how Nix is installed, so I can't upgrade it"); | ||
|
||
printInfo("found Nix in '%s'", where); | ||
|
||
if (hasPrefix(where, "/run/current-system")) | ||
throw Error("Nix on NixOS must be upgraded via 'nixos-rebuild'"); | ||
|
||
Path profileDir; | ||
Path userEnv; | ||
|
||
if (baseNameOf(where) != "bin" || | ||
!hasSuffix(userEnv = canonPath(profileDir = dirOf(where), true), "user-environment")) | ||
throw Error("directory '%s' does not appear to be part of a Nix profile", where); | ||
|
||
if (!store->isValidPath(userEnv)) | ||
throw Error("directory '%s' is not in the Nix store", userEnv); | ||
|
||
return profileDir; | ||
} | ||
|
||
/* Return the store path of the latest stable Nix. */ | ||
Path getLatestNix(ref<Store> store) | ||
{ | ||
// FIXME: use nixos.org? | ||
auto req = DownloadRequest("https://github.com/NixOS/nixpkgs/raw/master/nixos/modules/installer/tools/nix-fallback-paths.nix"); | ||
auto res = getDownloader()->download(req); | ||
|
||
EvalState state(Strings(), store); | ||
auto v = state.allocValue(); | ||
state.eval(state.parseExprFromString(*res.data, "/no-such-path"), *v); | ||
Bindings & bindings(*state.allocBindings(0)); | ||
auto v2 = findAlongAttrPath(state, settings.thisSystem, bindings, *v); | ||
|
||
return state.forceString(*v2); | ||
} | ||
}; | ||
|
||
static RegisterCommand r1(make_ref<CmdUpgradeNix>()); |
6fa6902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this fail if you're using unstable and the latest stable is "older"?
6fa6902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.