Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moreutils: Fix eval #34474

Merged
merged 1 commit into from Jan 31, 2018
Merged

moreutils: Fix eval #34474

merged 1 commit into from Jan 31, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 31, 2018 •
edited

Motivation for this change

Was broken in 561b9ca.

Please use @GrahamcOfBorg everyone!!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Ericson2314 referenced this pull request Jan 31, 2018
@pSub
moreutils: 0.61 -> 0.62
561b9ca
@Ericson2314
Copy link
Member Author

Ericson2314 commented Jan 31, 2018 •
edited

I guess @GrahamcOfBorg fails it because it fails everything when master is broken? Indeed: NixOS/ofborg#25

@Ericson2314 Ericson2314 merged commit b8e8265 into NixOS:master Jan 31, 2018
@Ericson2314 Ericson2314 deleted the fix-eval branch January 31, 2018 22:20
@grahamc
Copy link
Member

grahamc commented Jan 31, 2018

Indeed: NixOS/ofborg#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @grahamc