Add Sha3 Hash Functions #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blake performance numbers for reference:
```
Cpu: Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
```
-- Blake2s
```
Zig --release-fast
485 Mb/s
Zig --release-safe
377 Mb/s
Zig
11 Mb/s
```
-- Blake2b
```
Zig --release-fast
616 Mb/s
Zig --release-safe
573 Mb/s
Zig
18 Mb/s
```
These are on the slower side and could be improved. No performance optimizations
yet have been done.
```
Cpu: Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
```
-- Sha3-256
```
Zig --release-fast
93 Mb/s
Zig --release-safe
99 Mb/s
Zig
4 Mb/s
```
-- Sha3-512
```
Zig --release-fast
49 Mb/s
Zig --release-safe
54 Mb/s
Zig
2 Mb/s
```
Interestingly, release-safe is producing slightly better code than
release-fast.
|
That's really strange. I can't think of any reason why release-safe could be faster than release-fast. I'll have to dig into the assembly. |
tiehuis
commented
Jan 17, 2018
| // TODO: Cannot unroll all loops here due to comptime differences. | ||
| inline for (RC[0..no_rounds]) |round| { | ||
| // theta | ||
| x = 0; while (x < 5) : (x += 1) { |
There was a problem hiding this comment.
I haven't been able to inline statements like these without getting wrong results in the tests. Is there any open issues relating to this or am I missing something? Or just a bug?
For example, making making y comptime and inline all the whiles results in bad results.
There was a problem hiding this comment.
It's probably a bug. I'm going to bed now but I'll have a look tomorrow. I'll prioritize this bug since it's a silently invalid code bug.
|
Code looks good. Feel free to merge when the tests pass (or if you already ran the tests before making the PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are on the slower side and could be improved. No performance optimizations
yet have been done.
Sha3-256
Sha3-512
Interestingly, release-safe is producing slightly better code than
release-fast.
Also, the blake numbers which I hadn't measured on their commit:
Blake2s
Blake2b