Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.extfat-nofuse: fix libelf dependency #33963

Merged
merged 1 commit into from Jan 17, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jan 17, 2018

Motivation for this change

Added missing backport that is required with the latest 4.14 kernel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jan 17, 2018

@GrahamcOfBorg build linuxPackages_4_14.exfat-nofuse linuxPackages_4_4.exfat-nofuse

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/exfat/default.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:74:12:
while evaluating 'versionAtLeast' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/strings.nix:363:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/exfat/default.nix:5:8:
while evaluating 'versionOlder' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/strings.nix:351:22, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/strings.nix:363:29:
while evaluating the attribute 'linux_4_14' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/top-level/all-packages.nix:12356:3:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/top-level/all-packages.nix:12356:16:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:74:12:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/kernel/generic.nix:33:1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gpjzjdkqy4bklrf0x9582zid58pda4ay-exfat-nofuse-2017-06-19-4.14.13
shrinking /nix/store/gpjzjdkqy4bklrf0x9582zid58pda4ay-exfat-nofuse-2017-06-19-4.14.13/lib/modules/4.14.13/kernel/fs/exfat/exfat.ko
wrong ELF type
stripping (with flags -S) in /nix/store/gpjzjdkqy4bklrf0x9582zid58pda4ay-exfat-nofuse-2017-06-19-4.14.13/lib 
patching script interpreter paths in /nix/store/gpjzjdkqy4bklrf0x9582zid58pda4ay-exfat-nofuse-2017-06-19-4.14.13
checking for references to /tmp/nix-build-exfat-nofuse-2017-06-19-4.14.13.drv-0 in /nix/store/gpjzjdkqy4bklrf0x9582zid58pda4ay-exfat-nofuse-2017-06-19-4.14.13...
wrong ELF type
/nix/store/gpjzjdkqy4bklrf0x9582zid58pda4ay-exfat-nofuse-2017-06-19-4.14.13
/nix/store/7k6sn486nkd8fnf3z8clznvng2l3m4z3-exfat-nofuse-2017-06-19-4.4.111

@andir andir merged commit a3b0950 into NixOS:release-17.09 Jan 17, 2018
@andir andir deleted the 17.09/exfat-nofuse branch January 17, 2018 02:24
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

  LD [M]  /build/exfat-nofuse-de4c760bc9a05ead83bc3ec6eec6cf1fb106f523-src/exfat.ko
/nix/store/87z9n9w70q8xmp2dsxanx7gr7q77j0zs-binutils-2.28.1/bin/ld: cannot open linker script file /nix/store/rggld23558fyzpzph120173496k18k0f-linux-4.14.13-dev/lib/modules/4.14.13/source/arch/arm64/kernel/module.lds: No such file or directory
make[4]: *** [/nix/store/rggld23558fyzpzph120173496k18k0f-linux-4.14.13-dev/lib/modules/4.14.13/source/scripts/Makefile.modpost:129: /build/exfat-nofuse-de4c760bc9a05ead83bc3ec6eec6cf1fb106f523-src/exfat.ko] Error 1
make[3]: *** [/nix/store/rggld23558fyzpzph120173496k18k0f-linux-4.14.13-dev/lib/modules/4.14.13/source/Makefile:1511: modules] Error 2
make[2]: *** [Makefile:146: sub-make] Error 2
make[1]: *** [Makefile:24: __sub-make] Error 2
make[1]: Leaving directory '/nix/store/rggld23558fyzpzph120173496k18k0f-linux-4.14.13-dev/lib/modules/4.14.13/build'
make: *** [Makefile:35: all] Error 2
builder for '/nix/store/fhgc8ivmlmcjq5zz28bbpj6hmhj6nahs-exfat-nofuse-2017-06-19-4.14.13.drv' failed with exit code 2
error: build of '/nix/store/fhgc8ivmlmcjq5zz28bbpj6hmhj6nahs-exfat-nofuse-2017-06-19-4.14.13.drv', '/nix/store/xlying3nn5q65s4yx4ijp48ar99xrhgv-exfat-nofuse-2017-06-19-4.4.111.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants