Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-cli: use as much memory as possible #33968

Merged
merged 1 commit into from Jan 18, 2018
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Instead of imposing an arbitrary memory limit via php.ini, let wp-cli use as
much as possible. If you need to limit the memory use, there are mechanisms in
your OS far better suited for this.

Cc: @grahamc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Instead of imposing an arbitrary memory limit via php.ini, let wp-cli use as
much as possible. If you need to limit the memory use, there are mechanisms in
your OS far better suited for this.
@peterhoeg peterhoeg merged commit 08d3da7 into NixOS:master Jan 18, 2018
@peterhoeg peterhoeg deleted the f/wp branch January 18, 2018 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants