Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytestrunner: 2.6.2 -> 3.0 #33977

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pytestrunner: 2.6.2 -> 3.0 #33977

wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 17, 2018 •
edited

Also add missing dependency to progressbar2

Not yet tested whether this solves the issue, build still running
progressbar2 build fine now.

Those 501+ rebuilds are a little scary.
Is a test via nox-review sufficient? But I fear such a test would take days on my machine.

Motivation for this change

See #33920.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @ashgillman @FRidh

pythonPackages.pytestrunner: 2.6.2 -> 3.0
92fea7e 
Also add missing dependency to progressbar2
@dotlambda dotlambda requested a review from FRidh as a code owner January 17, 2018 11:04
@ashgillman
Copy link
Contributor

How do you review with nox? I have run nox-review wip --against master, seems to be building 411 packages.

I have also added:

⚡ cat .config/nixpkgs/nix.conf
gc-keep-outputs = true
build-max-jobs = 5
build-cores = 2
build-use-sandbox = true

How can I verify that I am indeed building in a sandbox?

@dotlambda
Copy link
Member Author

nox-review wip --against master seems to be fine.

Just try building progressbar2 without the pytestrunner dependency. It should print errors about network access.
Or write your own derivation that accesses network in the buildPhase and try to build it.

@dotlambda
Copy link
Member Author

@FRidh Should this be merged into staging instead of master?

@FRidh FRidh mentioned this pull request Jan 20, 2018
Merged
8 tasks
@FRidh
Copy link
Member

FRidh commented Jan 20, 2018

Thanks! I'm including this in #34077.

@FRidh FRidh closed this Jan 20, 2018
@dotlambda dotlambda deleted the pytestrunner branch February 8, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @ashgillman @FRidh @GrahamcOfBorg