Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5: reduce evaluation memory use #33747

Merged
merged 1 commit into from Jan 11, 2018
Merged

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jan 11, 2018

Motivation

Memory use prohibits adding new Qt package sets. Removing recurseIntoAttrs from libsForQt5 reduces memory use by ~60 MB per platform.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel self-assigned this Jan 11, 2018
@ttuegel
Copy link
Member Author

ttuegel commented Jan 11, 2018

See #33297.

@ttuegel ttuegel merged commit 7fedfea into NixOS:master Jan 11, 2018
@ttuegel ttuegel deleted the bugfix/qt-5/eval-size branch January 11, 2018 14:36
@LnL7
Copy link
Member

LnL7 commented Jan 11, 2018

FYI. It looks like hydra.nixos.org already has a higher heapsize configured, we could do the same for ofborg.

@dtzWill dtzWill mentioned this pull request Feb 7, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants