Compiler: ensure parentheses inside assign value #5571
Closed
+39
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5568
As the issue mentions, this code:
will print this from the
debug
part of the macro:The issue is that
x = ...
is incorrectly printed with theto_s
method of an ASTNode because it's either missing parentheses orbegin/end
so that its value is the last expression (not the first one here). So this PR fixes that.Eventually, I think it might be better to make this expansion happen after macro code, so showing that macro code would show the original
foo[:foo] += 1
. In any case, this fix is more general because fixing theto_s
should be done regardless of this other possible enhancement.