Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cassandra: version bump 2.1.15->2.1.19, 2.2.9->2.2.11, 3.0.9->3.0.15 #33743

Merged
merged 3 commits into from Feb 7, 2018
Merged

cassandra: version bump 2.1.15->2.1.19, 2.2.9->2.2.11, 3.0.9->3.0.15 #33743

merged 3 commits into from Feb 7, 2018

Conversation

fuzzy-id
Copy link
Contributor

Motivation for this change

Bump older (but still supported) versions of Apache Cassandra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I used the new tests of #31410. This tests nodetool, cqlsh and building a cassandra cluster.

@adisbladis
Copy link
Member

@GrahamcOfBorg eval

@fuzzy-id fuzzy-id mentioned this pull request Jan 11, 2018
Merged
@roberth
Copy link
Member

roberth commented Jan 12, 2018

LGTM

@roberth
Copy link
Member

roberth commented Feb 6, 2018

@adisbladis These build fine. Can they be merged?

@adisbladis
Copy link
Member

adisbladis commented Feb 7, 2018 •
edited

@fuzzy-id We generally like to have one commit per version bump.
I split up your commits and rebased on current master.

Thanks! :)

@adisbladis adisbladis merged commit fc1224d into NixOS:master Feb 7, 2018
@fuzzy-id fuzzy-id deleted the cassandra-bump branch February 7, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fuzzy-id @adisbladis @roberth @GrahamcOfBorg