tifffile: init at v0.13.0 #33750
Merged
tifffile: init at v0.13.0 #33750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheckemann
reviewed
Jan 11, 2018
|
|
||
| buildInputs = [ nose ]; | ||
|
|
||
| propagatedBuildInputs = [ numpy ] ++ lib.optional isPy27 futures ++ lib.optional (pythonOlder "3.0") enum34; |
There was a problem hiding this comment.
Would [ numpy ] ++ lib.optionals (!isPy3k) [ futures enum34 ] maybe be more suitable?
There was a problem hiding this comment.
This expression is equal this piece of code in setup.py:
'enum34;python_version<"3.0"',
'futures; python_version == "2.7"'
|
@GrahamcOfBorg build python2Packages.tifffile python3Packages.tifffile |
There was a problem hiding this comment.
Success for system: x86_64-linux
writing manifest file 'tifffile.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-3.6/tifffile/_tifffile.cpython-36m-x86_64-linux-gnu.so -> tifffile
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/q68yi4pgb4k49msvxs9h6yvzzzv5rnmd-python2.7-tifffile-v0.13.0
/nix/store/g3y6z62awz2vna3y66b9jwcaxm38893q-python3.6-tifffile-v0.13.0
There was a problem hiding this comment.
Success for system: x86_64-darwin
Ran 0 tests in 0.000s
OK
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/vhm5j5872rb4fzlgpvavgpy4aam67clj-python2.7-tifffile-v0.13.0
/nix/store/fg9wiwf2x11j8nqpfn5k5b61asb13iai-python3.6-tifffile-v0.13.0
There was a problem hiding this comment.
Success for system: aarch64-linux
writing manifest file 'tifffile.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-aarch64-3.6/tifffile/_tifffile.cpython-36m-aarch64-linux-gnu.so -> tifffile
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/yyni705pl3a0ypdp148i4vkb8vgcbs6f-python2.7-tifffile-v0.13.0
/nix/store/a2hlcghf4vxybkjy1g86h4axdg5smp5z-python3.6-tifffile-v0.13.0
FRidh
requested changes
Jan 11, 2018
| buildPythonPackage rec { | ||
| pname = "tifffile"; | ||
| rev = "v0.13.0"; | ||
| name = "${pname}-${rev}"; |
| rev = "v0.13.0"; | ||
| name = "${pname}-${rev}"; | ||
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
is fetching from PyPI not possible?
| sha256 = "0adm1zf3b4gf8yjriidjnl9abcycqiy5bzannwyb8rcbh3jwdbzv"; | ||
| }; | ||
|
|
||
| buildInputs = [ nose ]; |
|
|
||
| propagatedBuildInputs = [ numpy ] ++ lib.optional isPy27 futures ++ lib.optional (pythonOlder "3.0") enum34; | ||
|
|
||
| meta = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I needed to read a 16bit tiff files with python. Tifffile reads tiff into numpy array.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)