Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly represent all encodings in methods/constants/variables/symbols #4965

Closed
enebo opened this issue Jan 11, 2018 · 2 comments
Closed

Properly represent all encodings in methods/constants/variables/symbols #4965

enebo opened this issue Jan 11, 2018 · 2 comments
Labels
Milestone

Comments

@enebo
Copy link
Member

enebo commented Jan 11, 2018

JRuby has had a limitation up through JRuby 9.1.x where some indentifiers which do not properly map to a Java charset are not possible beacuse internally we store all identifiers as Java Strings.

The solution to this is partially to move as much internally to using ByteList as we can. For things where this would not work out well we will still use java.lang.String but we will store those strings as an iso_8859_1 raw piece of data. Anything which accesses those String will need also to have their encoding and if they don't we will assume they are utf-8 data. This largely will allow things we could not do in the past to start working but things from the past which did work will still work since pretty much everything is utf-8.

@enebo enebo added the feature label Jan 11, 2018
@enebo enebo added this to the JRuby 9.2.0.0 milestone Jan 11, 2018
@enebo
Copy link
Member Author

enebo commented Jan 11, 2018

Current work in progress for this feature is happening on bytelist_love. This feature should still figure out all issues reported against encoding issues and attach them to this issue.

@headius headius mentioned this issue Mar 27, 2018
15 tasks
@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 24, 2018
@enebo
Copy link
Member Author

enebo commented Jun 12, 2018

Closing this feature (should have for 9.2.0.0). Only #3688 is not fixed and it is targetted for 9.2.1.0. I will look into it (it might not even technically be part of this...unsure).

@enebo enebo closed this as completed Jun 12, 2018
@enebo enebo modified the milestones: JRuby 9.2.1.0, JRuby 9.2.0.0 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant