Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Spark address CVE-2017-12612 #33739

Merged
merged 3 commits into from Jan 11, 2018
Merged

Apache Spark address CVE-2017-12612 #33739

merged 3 commits into from Jan 11, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jan 11, 2018

Motivation for this change

During a routine check I found that our current Apache Spark version is affected by CVE-2017-12612.

This PR removed the ancient Apache Spark version form the 1.6 branch. It doesn't receive any updates anymore.

Any objections?

CC maintainers and contributors: @thoughtpolice @offlinehacker @cko @mboes @samuelrivas @NixOS/security-notifications

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jan 11, 2018

@GrahamcOfBorg build spark

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: while evaluating the attribute 'buildInputs' of the derivation 'spark-2.2.1' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:143:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u152b16' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:143:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:143:11:
No bootstrap for system

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘mesos-1.4.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/networking/cluster/mesos/default.nix:249 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/sbin/stop-mesos-dispatcher.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/sbin/stop-mesos-shuffle-service.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/sbin/start-history-server.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/sbin/stop-all.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/sbin/stop-shuffle-service.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/python/run-tests.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/bin/python"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/python/run-tests: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1/lib/spark-2.2.1-bin-hadoop2.7/python/pyspark/find_spark_home.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/bin/python"
checking for references to /tmp/nix-build-spark-2.2.1.drv-0 in /nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1...
/nix/store/cx2b3f2g3kk98558q5bmjaqm97qi60qh-spark-2.2.1

@andir andir merged commit 856d9c2 into NixOS:master Jan 11, 2018
@andir andir deleted the spark branch January 11, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants