Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libinput: 1.9.3 -> 1.9.4 #34122

Closed
wants to merge 13 commits into from
Closed

libinput: 1.9.3 -> 1.9.4 #34122

wants to merge 13 commits into from

Conversation

kamidon
Copy link
Contributor

@kamidon kamidon commented Jan 22, 2018

Motivation for this change

This rev-bump of libinput resolves issues with out of order key press
delivery as described here:

https://lists.freedesktop.org/archives/wayland-devel/2017-December/036147.html

Things done

In addition to the items below, I've been running this change in an overlay of unstable on two NixOS computers for several weeks without any problems.

  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Fits CONTRIBUTING.md.

lsix and others added 10 commits January 11, 2018 11:17
TODO: verify that S3TC works without adding libtxc*,
and clean all the related code.
Close NixOS#33281.  Edits by vcunat:
 - use Eelco's idea: empty file instead of full copy
 - use longer name suffix to decrease the likelihood of collision
Hydra: ?compare=1428079
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2018

Can you change the branch from master to staging, since this change rebuilds many packages?
You will need to force push your commit on the other branch, since there will be other commits not present in staging.

@kamidon
Copy link
Contributor Author

kamidon commented Jan 22, 2018

Closed and replaced by PR #34160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants