Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunspell: 1.6.1 -> 1.6.2 #34124

Merged
merged 1 commit into from Feb 10, 2018
Merged

hunspell: 1.6.1 -> 1.6.2 #34124

merged 1 commit into from Feb 10, 2018

Conversation

arcadio
Copy link
Contributor

@arcadio arcadio commented Jan 22, 2018

Motivation for this change

Upgrade hunspell to latest stable release, which fixes important encoding bug. See:

https://github.com/hunspell/hunspell/releases/tag/v1.6.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Fuuzetsu

@grahamc
Copy link
Member

grahamc commented Jan 24, 2018

@GrahamcOfBorg build hunspell

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fzwblgy3cd571wagw8bl2hgxm3spdpla-hunspell-1.6.2-dev/lib
patching script interpreter paths in /nix/store/fzwblgy3cd571wagw8bl2hgxm3spdpla-hunspell-1.6.2-dev
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qaamf61rqbpv1y2vpn05hnic2p2pqyq9-hunspell-1.6.2/lib
patching script interpreter paths in /nix/store/qaamf61rqbpv1y2vpn05hnic2p2pqyq9-hunspell-1.6.2
gzipping man pages under /nix/store/zvkpdigj9knbp7ivkvyg4b7cjnix47xk-hunspell-1.6.2-man/share/man/
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/zvkpdigj9knbp7ivkvyg4b7cjnix47xk-hunspell-1.6.2-man
/nix/store/l8yanad1r61nhvfdn7kd7b4j4lkb174b-hunspell-1.6.2-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/987r60w7jxpxf3gkvxidmpryjkbb7msh-hunspell-1.6.2/lib 
patching script interpreter paths in /nix/store/987r60w7jxpxf3gkvxidmpryjkbb7msh-hunspell-1.6.2
checking for references to /tmp/nix-build-hunspell-1.6.2.drv-0 in /nix/store/987r60w7jxpxf3gkvxidmpryjkbb7msh-hunspell-1.6.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/7rrqbbhr3l77z6wvilmfzcrhyr20yf7r-hunspell-1.6.2-man
gzipping man pages under /nix/store/7rrqbbhr3l77z6wvilmfzcrhyr20yf7r-hunspell-1.6.2-man/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7rrqbbhr3l77z6wvilmfzcrhyr20yf7r-hunspell-1.6.2-man
checking for references to /tmp/nix-build-hunspell-1.6.2.drv-0 in /nix/store/7rrqbbhr3l77z6wvilmfzcrhyr20yf7r-hunspell-1.6.2-man...
/nix/store/82kvw1v9ybcl2jgc3miwc22106y2i2gy-hunspell-1.6.2-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/frgxin3f4flgbdc99kjl9dnnfs77danb-hunspell-1.6.2/lib
patching script interpreter paths in /nix/store/frgxin3f4flgbdc99kjl9dnnfs77danb-hunspell-1.6.2
checking for references to /build in /nix/store/frgxin3f4flgbdc99kjl9dnnfs77danb-hunspell-1.6.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/fsq94vm8py7x6zwnpwaazkcq9ixc33rj-hunspell-1.6.2-man
gzipping man pages under /nix/store/fsq94vm8py7x6zwnpwaazkcq9ixc33rj-hunspell-1.6.2-man/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/fsq94vm8py7x6zwnpwaazkcq9ixc33rj-hunspell-1.6.2-man
checking for references to /build in /nix/store/fsq94vm8py7x6zwnpwaazkcq9ixc33rj-hunspell-1.6.2-man...
/nix/store/l4b1c3diw1v0mz5phgiadsxfnil9jvyr-hunspell-1.6.2-bin

@Mic92 Mic92 merged commit 5c22bf8 into NixOS:master Feb 10, 2018
@arcadio arcadio deleted the hunspell branch May 14, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants