Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbound: Fix CVE-2017-15105 #34114

Closed
wants to merge 1 commit into from
Closed

unbound: Fix CVE-2017-15105 #34114

wants to merge 1 commit into from

Conversation

corpix
Copy link
Contributor

@corpix corpix commented Jan 21, 2018 •
edited

Motivation for this change

I was looking at unbound and discovered it has a CVE for which nixpkgs does not have a patch.

Upstream ships a patch for 1.6.7 but it failed to apply, so I have wget unbound-1.6.7.tgz && tar x && git init && patch && git diff to generate a patch. There is also a new version(1.6.8) of unbound, looks like it was shiped just to fix this CVE so I have two commits:

  1. patch 1.6.7
  2. update to 1.6.8

Probably they should be squashed, what should I do?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 21, 2018
@vcunat
Copy link
Member

vcunat commented Jan 21, 2018

Squash all together, though we can do it with the green button as well. I believe the update is the best course, to staging and release-17.09 branches. /cc maintainers @fpletz, @ehmry.

@corpix corpix requested a review from FRidh as a code owner January 21, 2018 19:09
@corpix corpix changed the base branch from master to staging January 21, 2018 19:10
@corpix
Copy link
Contributor Author

corpix commented Jan 21, 2018 •
edited

Hmmm, strange, I could merge it into staging a0f8e3a of my local nixpkgs copy, but checks says "Failed to merge"

upd:
Probably I have pushed too quickly :) Now checks are fine.

vcunat added a commit that referenced this pull request Jan 22, 2018
@vcunat
Merge #34114: unbound: 1.6.7 -> 1.6.8 (security)
8b49697 
CVE-2017-15105
@vcunat
Copy link
Member

vcunat commented Jan 22, 2018

I merged an older version of this PR (resulting into the same tree); staging 8b49697 and 17.09 8551e2c.

@vcunat vcunat closed this Jan 22, 2018
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corpix @vcunat @GrahamcOfBorg @TredwellGit