newsboat: clean up and fix on Darwin #34120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build newsboat |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
clang++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/nix/store/by2nxmg543s81s9ffq55p2zmwf4r3hay-newsboat-2.10.2/share/locale\" -I/nix/store/g7v6lzy4kw1c7xiak8n49xs3y7v67v6n-sqlite-3.21.0-dev/include -I/nix/store/sv4anzzzy208msiz8vqqkaln7khf01jc-curl-7.57.0-dev/include -I/nix/store/hqjk6s39s6vpkfjmmq1spcg67hcvgwm9-libxml2-2.9.7-dev/include/libxml2 -I/include -I/nix/store/wy6ymh7rr9r87qjvxzi3s79gip72s8lk-json-c-0.12.1-dev/include/json-c -D_DARWIN_C_SOURCE -I/nix/store/jp2f4v52cw36xwdjlp8s23i29a3xfbp6-ncurses-6.0-20171125-dev/include/ncursesw -I/nix/store/jp2f4v52cw36xwdjlp8s23i29a3xfbp6-ncurses-6.0-20171125-dev/include -o src/logger.o -c src/logger.cpp
clang++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/nix/store/by2nxmg543s81s9ffq55p2zmwf4r3hay-newsboat-2.10.2/share/locale\" -I/nix/store/g7v6lzy4kw1c7xiak8n49xs3y7v67v6n-sqlite-3.21.0-dev/include -I/nix/store/sv4anzzzy208msiz8vqqkaln7khf01jc-curl-7.57.0-dev/include -I/nix/store/hqjk6s39s6vpkfjmmq1spcg67hcvgwm9-libxml2-2.9.7-dev/include/libxml2 -I/include -I/nix/store/wy6ymh7rr9r87qjvxzi3s79gip72s8lk-json-c-0.12.1-dev/include/json-c -D_DARWIN_C_SOURCE -I/nix/store/jp2f4v52cw36xwdjlp8s23i29a3xfbp6-ncurses-6.0-20171125-dev/include/ncursesw -I/nix/store/jp2f4v52cw36xwdjlp8s23i29a3xfbp6-ncurses-6.0-20171125-dev/include -o src/exception.o -c src/exception.cpp
clang++ -std=c++11 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/nix/store/by2nxmg543s81s9ffq55p2zmwf4r3hay-newsboat-2.10.2/share/locale\" -I/nix/store/g7v6lzy4kw1c7xiak8n49xs3y7v67v6n-sqlite-3.21.0-dev/include -I/nix/store/sv4anzzzy208msiz8vqqkaln7khf01jc-curl-7.57.0-dev/include -I/nix/store/hqjk6s39s6vpkfjmmq1spcg67hcvgwm9-libxml2-2.9.7-dev/include/libxml2 -I/include -I/nix/store/wy6ymh7rr9r87qjvxzi3s79gip72s8lk-json-c-0.12.1-dev/include/json-c -D_DARWIN_C_SOURCE -I/nix/store/jp2f4v52cw36xwdjlp8s23i29a3xfbp6-ncurses-6.0-20171125-dev/include/ncursesw -I/nix/store/jp2f4v52cw36xwdjlp8s23i29a3xfbp6-ncurses-6.0-20171125-dev/include -o src/utils.o -c src/utils.cpp
src/utils.cpp:9:10: fatal error: 'iconv.h' file not found
#include <iconv.h>
^~~~~~~~~
1 error generated.
make: *** [Makefile:113: src/utils.o] Error 1
builder for '/nix/store/mal2pxvvmz58dfv58kyfm43v4i8lqinq-newsboat-2.10.2.drv' failed with exit code 2
error: build of '/nix/store/mal2pxvvmz58dfv58kyfm43v4i8lqinq-newsboat-2.10.2.drv' failed
There was a problem hiding this comment.
Success for system: x86_64-linux
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2/bin
patching script interpreter paths in /nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2
/nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2/contrib/getpocket.com/send-to-pocket.sh: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2/contrib/getpocket.com/create-pocket-user-token.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2/contrib/bookmark-scuttle.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2/contrib/bookmark-pinboard.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2/contrib/bookmark-delicious.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-newsboat-2.10.2.drv-0 in /nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2...
/nix/store/4n625czqgrdws1db41wj5s7f5pykg27c-newsboat-2.10.2
|
@Mic92 Could you please trigger another build? |
There was a problem hiding this comment.
Success for system: aarch64-linux
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2/bin
patching script interpreter paths in /nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2
/nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2/contrib/bookmark-delicious.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2/contrib/bookmark-pinboard.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2/contrib/bookmark-scuttle.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2/contrib/getpocket.com/create-pocket-user-token.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2/contrib/getpocket.com/send-to-pocket.sh: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2...
/nix/store/fydv8f6gjhcdw9q7c25vca0ifydpa1xl-newsboat-2.10.2
|
@GrahamcOfBorg build newsboat |
1 similar comment
|
@GrahamcOfBorg build newsboat |
There was a problem hiding this comment.
Success for system: x86_64-linux
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2/bin
patching script interpreter paths in /nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2
/nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2/contrib/getpocket.com/create-pocket-user-token.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2/contrib/getpocket.com/send-to-pocket.sh: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2/contrib/bookmark-delicious.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2/contrib/bookmark-scuttle.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2/contrib/bookmark-pinboard.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-newsboat-2.10.2.drv-0 in /nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2...
/nix/store/784ldpngll0nrqb7lzazg315vav97854-newsboat-2.10.2
There was a problem hiding this comment.
Success for system: x86_64-darwin
gzipping man pages under /nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/share/man/
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/bin
patching script interpreter paths in /nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2
/nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/contrib/bookmark-delicious.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/sh"
/nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/contrib/bookmark-pinboard.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/sh"
/nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/contrib/bookmark-scuttle.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/sh"
/nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/contrib/getpocket.com/create-pocket-user-token.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/sh"
/nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2/contrib/getpocket.com/send-to-pocket.sh: interpreter directive changed from "/bin/bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/w4xqfxn5cn6xbg79wrp6kn69i73c1yf0-newsboat-2.10.2
|
I believe this can be merged. |
Mic92
reviewed
Jan 22, 2018
| ''; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig asciidoc docbook_xml_dtd_45 libxslt docbook_xml_xslt ] | ||
| nativeBuildInputs = [ pkgconfig asciidoc docbook_xml_dtd_45 libxslt docbook_xml_xslt libiconv ] |
There was a problem hiding this comment.
This is only a dependency on darwin and should be move in the optional block a line below.
There was a problem hiding this comment.
Actually, iconv.h is referenced in utils.cpp so it is a dependency on both, Darwin and Linux.
But maybe it's in one of the dependenies' propagatedBuildInputs for Linux only.
There was a problem hiding this comment.
Oh I see, libiconv is not needed on Linux because it is part of the standard library. Fixing it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Build is currently broken on Darwin: https://hydra.nixos.org/build/67522006/nixlog/1
I am not able to test whether this actually fixes it.
Also, I noticed a
-DLOCALEDIR=\"/usr/share/locale\"in the output ofmake.Finally I followed some suggestions from @nicknovitski's comment:
contrib/to$outandOn a side note, can someone please close #31719?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)cc @joachifm