Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectre-meltdown-checker: 0.31 -> 0.32 #34106

Merged
merged 1 commit into from Jan 21, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

cc @andir

@andir
Copy link
Member

andir commented Jan 21, 2018

@GrahamcOfBorg build spectre-meltdown-checker

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘spectre-meltdown-checker-0.32’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/tools/security/spectre-meltdown-checker/default.nix:28 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32/lib  /nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32/bin
patching script interpreter paths in /nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32
/nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32/lib/spectre-meltdown-checker.sh: interpreter directive changed from " /bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32...
/nix/store/7ajj8hhiyah02zlld82lnp40h65pfch0-spectre-meltdown-checker-0.32

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32/lib  /nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32/bin 
patching script interpreter paths in /nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32
/nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32/lib/spectre-meltdown-checker.sh: interpreter directive changed from " /bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-spectre-meltdown-checker-0.32.drv-0 in /nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32...
/nix/store/jy883wbqkf7dipbcag2q5awrpwi34qqb-spectre-meltdown-checker-0.32

@andir andir merged commit f2e5b7e into NixOS:master Jan 21, 2018
@dotlambda
Copy link
Member Author

Thanks!

@dtzWill
Copy link
Member

dtzWill commented Jan 22, 2018

It's showing vulnerable for variants 1 and 2, running latest unstable, with latest kernel. Is this expected?

nix-info -m:

  • system: "x86_64-linux"
  • host os: Linux 4.14.14, NixOS, 18.03pre125953.5402412b972 (Impala)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 1.12dtz5869_f8d9aed
  • channels(will): "allvm, unstable-18.03pre125130.3a763b91963"
  • channels(root): "nixos"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

@dotlambda
Copy link
Member Author

Yes it is.
According to https://www.phoronix.com/scan.php?page=news_item&px=Linux-4.9-4.14-Retpoline, the fixes should be available for the kernels available in Nixpkgs (>= 4.14.14 or >= 4.9.77)
But they need to be built with gcc >= 7.3, which is not yet available, according to https://www.phoronix.com/scan.php?page=news_item&px=GCC-7-Gets-Retpolines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants