Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hy to latest version #34116

Merged
merged 1 commit into from Jan 24, 2018
Merged

Update hy to latest version #34116

merged 1 commit into from Jan 24, 2018

Conversation

brown131
Copy link
Contributor

Motivation for this change

The current verson of Hy is out-of-date. Pypi has the latest version.

https://pypi.python.org/pypi/hy/0.13.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 21, 2018

@GrahamcOfBorg build hy

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin


----------------------------------------------------------------------
Ran 34 tests in 22.336s

FAILED (errors=2, skipped=1)
Test failed: <unittest.runner.TextTestResult run=34 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=34 errors=2 failures=0>
builder for '/nix/store/mqy9bp56lm5j91lvlbjyziz4hn0fhbys-python2.7-astor-0.6.2.drv' failed with exit code 1
cannot build derivation '/nix/store/d4xy6bd62glssjj50ib3693z6y62la41-hy-0.13.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/d4xy6bd62glssjj50ib3693z6y62la41-hy-0.13.1.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux


----------------------------------------------------------------------
Ran 34 tests in 21.944s

FAILED (errors=2, skipped=1)
Test failed: <unittest.runner.TextTestResult run=34 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=34 errors=2 failures=0>
builder for ‘/nix/store/cxbhq1r565yhqx7q7q3dvd08dvzc20lr-python2.7-astor-0.6.2.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/ljd3l276hijmnjdzdmk8pd4baxqkisbl-hy-0.13.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/ljd3l276hijmnjdzdmk8pd4baxqkisbl-hy-0.13.1.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux


----------------------------------------------------------------------
Ran 34 tests in 80.648s

FAILED (errors=2, skipped=1)
Test failed: <unittest.runner.TextTestResult run=34 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=34 errors=2 failures=0>
builder for '/nix/store/qn1ngp1a3ysn67km59srqv10pxj8iqca-python2.7-astor-0.6.2.drv' failed with exit code 1
cannot build derivation '/nix/store/9hayfa2bmj9pl1hc3nd8mrfbbjxk2kv8-hy-0.13.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9hayfa2bmj9pl1hc3nd8mrfbbjxk2kv8-hy-0.13.1.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jan 21, 2018

astor a dependency seems to be broken

@brown131
Copy link
Contributor Author

So the failed dependency means that this can't be updated until the astor dependency is fixed. Any idea how/when will that happen?

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2018

It could be updated, but it would be still broken or I can test if it would actually work, if astor is fixed.

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2018

I disabled the broken tests for now: 3b6b52b

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2018

@GrahamcOfBorg build hy

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

reading manifest file 'hy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'hy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/x822wjn0j69i3c3rhbcx0qs8lhbwid7g-hy-0.13.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

reading manifest file 'hy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'hy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/sg7jmpc7nmyjp4fwzai6lpbjq07hr3jg-hy-0.13.1

@Mic92 Mic92 merged commit a3d6f38 into NixOS:master Jan 24, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

reading manifest file 'hy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'hy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/qzyw2bxr15dv2pskgpj0z11hq0q11x3s-hy-0.13.1

@brown131 brown131 deleted the patch-1 branch January 24, 2018 22:55
@brown131
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants