Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tablib: 0.10.0 -> 0.12.1 #34115

Merged
merged 1 commit into from Jan 21, 2018
Merged

tablib: 0.10.0 -> 0.12.1 #34115

merged 1 commit into from Jan 21, 2018

Conversation

das-g
Copy link
Member

@das-g das-g commented Jan 21, 2018

(cherry picked from commit c323025)

Motivation for this change

See #33728

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@das-g das-g requested a review from FRidh as a code owner January 21, 2018 18:42
@das-g das-g mentioned this pull request Jan 21, 2018
Merged
8 tasks
@das-g das-g changed the title tablib: 0.10.0 -> 0.12.1, re-enable on Python 3 tablib: 0.10.0 -> 0.12.1 Jan 21, 2018
@das-g
tablib: 0.10.0 -> 0.12.1
d2541c4 
needs some additional build- and runtime dependencies that are also being added to the derivation with this commit

(cherry picked from commit c323025)
@das-g das-g force-pushed the tablib-0.12.1-cherrypicked-to-master branch from c62457f to d2541c4 Compare January 21, 2018 20:55
@das-g
Copy link
Member Author

das-g commented Jan 21, 2018

I've removed the "re-enable on Python 3" part from the tile of this PR and from the message of the commit produced by the cherry-picking, as that part of the change doesn't apply to master, where tablib hadn't been disabled for Python 3.

@Mic92 Mic92 merged commit f518ac7 into NixOS:master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @Mic92 @GrahamcOfBorg