Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver: 4.3.2 -> 4.3.3 #34129

Merged
merged 1 commit into from Jan 22, 2018
Merged

dbeaver: 4.3.2 -> 4.3.3 #34129

merged 1 commit into from Jan 22, 2018

Conversation

samueldr
Copy link
Member

Motivation for this change

New release:

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • 🚫 macOS
    • ✖️ other Linux distributions
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • ✔️ Fits CONTRIBUTING.md.
  • ✔️ Built using env -i NIX_REMOTE=daemon 'NIX_OTHER_STORES=/run/nix/remote-stores/*/nix' NIX_CONF_DIR=/etc/nix nix-build -A dbeaver

@adisbladis
Copy link
Member

@GrahamcOfBorg build dbeaver

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘dbeaver-ce-4.3.3’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/applications/misc/dbeaver/default.nix:59 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3
shrinking /nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3/dbeaver/dbeaver
shrinking /nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3/dbeaver/plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.551.v20171108-1834/eclipse_1630.so
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3/bin 
patching script interpreter paths in /nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3
checking for references to /tmp/nix-build-dbeaver-ce-4.3.3.drv-0 in /nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3...
/nix/store/3pgqnifl4fjvvd4pz3mc35s3y625xvjp-dbeaver-ce-4.3.3

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘dbeaver-ce-4.3.3’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/dbeaver/default.nix:59 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@adisbladis adisbladis merged commit 3d7dad7 into NixOS:master Jan 22, 2018
@adisbladis
Copy link
Member

@samueldr While I think that this version bump PR is fine (thanks!) we should ideally build everything we can from source.
I would really appreciate if we could change this derivation to use the source rather than pre-built binaries.

@samueldr
Copy link
Member Author

Hi @adisbladis, dbeaver is built exactly like eclipse is built. Its upstream build is using maven tooling, which few packages seem to do properly, and the attempt I made initially doesn't seem to want to build properly (with my experience with nix). There is one dependency in the maven dependency which seems troublesome to package (with the complete unfamiliarity I have with maven).

I would happily want to help and get help with getting a complete from-source build of dbeaver, but it definitely is out of my current skill set.

Here's my initial attempt I tried before looking at the eclipse package and seeing it trusted upstream binary builds:

The tycho bundle external bit makes using the existing maven patterns harder; I don't know maven, and it seems that adding it using mvn install:install-file isn't enough for it to work the way this maven use is done.


Anyway, this should be discussed in an issue instead of a merged PR; See issue #34182 for the followup.

@samueldr samueldr deleted the dbeaver/4.3.3 branch March 18, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants