init: kubectl at 1.7.9 (alias for kubernetes with only kubectl component) #34126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build kubectl |
There was a problem hiding this comment.
Success for system: x86_64-linux
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/b78z0gprvyyi6rmx73ri045ymnj4rbvk-kubectl-1.7.9-man
checking for references to /tmp/nix-build-kubectl-1.7.9.drv-0 in /nix/store/b78z0gprvyyi6rmx73ri045ymnj4rbvk-kubectl-1.7.9-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/4rvah8gadf9q7h0ic8fhwv9bf425pqys-kubectl-1.7.9-pause
shrinking /nix/store/4rvah8gadf9q7h0ic8fhwv9bf425pqys-kubectl-1.7.9-pause/bin/pause
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4rvah8gadf9q7h0ic8fhwv9bf425pqys-kubectl-1.7.9-pause/bin
patching script interpreter paths in /nix/store/4rvah8gadf9q7h0ic8fhwv9bf425pqys-kubectl-1.7.9-pause
checking for references to /tmp/nix-build-kubectl-1.7.9.drv-0 in /nix/store/4rvah8gadf9q7h0ic8fhwv9bf425pqys-kubectl-1.7.9-pause...
/nix/store/4wc1yw9xd4knnl3badxcbgnfwa1lhjr9-kubectl-1.7.9
There was a problem hiding this comment.
Success for system: x86_64-darwin
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/vw3k3a0150y99jdwdjdmwsdza17k0z9l-kubectl-1.7.9/bin
patching script interpreter paths in /nix/store/vw3k3a0150y99jdwdjdmwsdza17k0z9l-kubectl-1.7.9
gzipping man pages under /nix/store/y4znpvbg4g3jmfcwqn7ypj6s3gl1ri9c-kubectl-1.7.9-man/share/man/
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/y4znpvbg4g3jmfcwqn7ypj6s3gl1ri9c-kubectl-1.7.9-man
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bf9x4jq1qzky0ng1nvp6c1ywy4xqhz35-kubectl-1.7.9-pause/bin
patching script interpreter paths in /nix/store/bf9x4jq1qzky0ng1nvp6c1ywy4xqhz35-kubectl-1.7.9-pause
/nix/store/vw3k3a0150y99jdwdjdmwsdza17k0z9l-kubectl-1.7.9
There was a problem hiding this comment.
Failure for system: aarch64-linux
k8s.io/kubernetes/hack/cmd/teststale
k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
+++ [0124 01:32:41] Generating bindata:
test/e2e/generated/gobindata_util.go
/build/source /build/source/test/e2e/generated
/build/source/test/e2e/generated
+++ [0124 01:33:17] Building go targets for linux/arm64:
cmd/libs/go2idl/openapi-gen
building of '/nix/store/2kmsfqhlwp6c1bg6icbgpr5gisfk9r6z-kubectl-1.7.9.drv' timed out after 3200 seconds
error: build of '/nix/store/2kmsfqhlwp6c1bg6icbgpr5gisfk9r6z-kubectl-1.7.9.drv' failed
|
Huh. You'd think if the full kubernetes package didn't time out, neither would this one. |
|
Combined with this and I am happy: 😄 nixpkgs.config.packageOverrides = super: let self = super.pkgs; in {
kubernetes = (super.kubernetes.override { components = [ "cmd/kubectl" ]; }).overrideAttrs (oldAttrs: {
version = "1.9.2";
name = "kubectl-1.9.2";
src = pkgs.fetchFromGitHub {
owner = "kubernetes";
repo = "kubernetes";
rev = "v1.9.2";
sha256 = "0yf9k08ngplqb5xwipyfp25nlb19ykh05b7l9qcvybczihdkv6p2";
};
});
}; |
|
Yeah, that's almost exactly what we're doing in our local overlay, and it works fine for us. I don't really understand what's breaking in #33954, but hopefully it gets fixed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Developers who use the kubectl command-line to communicate with remote kubernetes servers don't benefit from compiling local versions of those servers. Also, the helm command-line tool depends only on kubectl, not all of kubernetes. This change makes installing either of those tools a bit quicker.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"