Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding performance_counter::reinit to allow for dynamically changing counter sets #3118

Merged
merged 2 commits into from Jan 24, 2018

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 21, 2018

  • This change adds a new API function for performance counters that instructs a
    counter to re-initialize the set of values it refers to
  • This also adds a new hpx::reinit_active_counters() API that triggers a
    reinit for all active counters

Any background context you want to provide?

We will need this functionality for the new performance counters to be created for Phylanx where the list of values to be returned from a performance counter may change dynamically based on the evaluated expressions.

@hkaiser
Copy link
Member Author

hkaiser commented Jan 21, 2018

@parsa This is a functionality you will need to use for the new Phylanx performance counters. After compiling the expression trees an application now should call hpx::reinit_active_counters() that will trigger re-scanning of the existing primitive instances inside the counters.

…counter sets

- This change adds a new API function for performance counters that instructs a
  counter to re-initialize the set of counters it refers to
- This also adds a new `hpx::reinit_active_counters()` API that triggers a
  reinit for all active counters
Copy link
Contributor

@parsa parsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and looks fine.

@hkaiser hkaiser merged commit 83ab578 into master Jan 24, 2018
@hkaiser hkaiser deleted the reinit_counters branch January 24, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants