Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable default executor compatibility with V1 executors #3119

Merged
merged 1 commit into from Jan 28, 2018
Merged

Disable default executor compatibility with V1 executors #3119

merged 1 commit into from Jan 28, 2018

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 21, 2018

  • this is in preparation with the V1.1. release at which point the V1 executors
    should be disabled by default
  • this also sets the default for HPX_HAVE_TRANSFORM_REDUCE_COMPATIBILITY to OFF

@hkaiser hkaiser added this to the 1.1.0 milestone Jan 21, 2018
@hkaiser hkaiser changed the title This patch disables default executor compatibility with V1 executors Disable default executor compatibility with V1 executors Jan 21, 2018
@hkaiser hkaiser force-pushed the disable_executor_compatibility branch 2 times, most recently from 03bd6cc to 27a034c Compare January 22, 2018 00:17
@sithhell
Copy link
Member

We could remove the v1 tests as well, can't we?

@hkaiser
Copy link
Member Author

hkaiser commented Jan 22, 2018

We could remove the v1 tests as well, can't we?

The only change for now is to disable the capabilities by default. I think we should remove the tests once we remove the functionality for V1.2.

@hkaiser hkaiser force-pushed the disable_executor_compatibility branch 4 times, most recently from 9838dca to f8fbdc6 Compare January 23, 2018 13:02
@hkaiser
This patch disables default executor compatibility with V1 executors
2651fc2 
- this is in preparation with the V1.1. release at which point the V1 executors
  should be disabled by default
- this also sets the default for HPX_HAVE_TRANSFORM_REDUCE_COMPATIBILITY to OFF
@hkaiser hkaiser force-pushed the disable_executor_compatibility branch from f8fbdc6 to 2651fc2 Compare January 26, 2018 17:03
@msimberg msimberg mentioned this pull request Jan 27, 2018
Closed
12 tasks
@hkaiser hkaiser merged commit 3e63f6a into master Jan 28, 2018
@hkaiser hkaiser deleted the disable_executor_compatibility branch January 28, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: executors type: compatibility issue
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell