Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pixie: 1356 -> 1367 #34118

Closed
wants to merge 1 commit into from
Closed

pixie: 1356 -> 1367 #34118

wants to merge 1 commit into from

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Jan 21, 2018

Motivation for this change

Update pixie to latest git version: pixie-lang/pixie@d76adb0

Pixie compiles successfully, but running it fails with:

± ./result/bin/pixie
in internal function run_load_stdlib

in internal function load-ns

in internal function load-file

in internal function load-reader

RuntimeException: <inst pixie.stdlib.Keyword> Var assoc is undefined

@alekcz do you have an idea, what's going on?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bendlas bendlas self-assigned this Jan 21, 2018
@alekcz
Copy link
Contributor

alekcz commented Jan 22, 2018

@bendlas the last merge broke the build. We need one of the maintainers to roll back to merge #531. The other problem is our build script on Travis doesn't pick up runtime errors. That's how the broken merge happened. I'm working to fix our build script.

See pixie-lang/pixie#535

@alekcz
Copy link
Contributor

alekcz commented Jan 22, 2018

@bendlas the last working build is:
https://github.com/pixie-lang/pixie/tree/5eb0ccbe8b0087d3a5f2d0bbbc6998d624d3cd62

@bendlas
Copy link
Contributor Author

bendlas commented Feb 5, 2018

committed the latest working version d5bc23c

@bendlas bendlas closed this Feb 5, 2018
@bendlas bendlas deleted the update-pixie branch October 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bendlas bendlas

Labels
2.status: work-in-progress 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendlas @alekcz @GrahamcOfBorg