Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Two cleanups to the cross compilation chapter #34302

Merged
merged 2 commits into from
Jan 26, 2018
Merged

doc: Two cleanups to the cross compilation chapter #34302

merged 2 commits into from
Jan 26, 2018
+12 −1

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 26, 2018 •
edited
Loading

Motivation for this change

Recent discussion on IRC convinced me the command tag didn't stand out enough. Also, after just making the issue, and I thought we should come clean in the manual.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @infinisil

Sorry, something went wrong.

@Ericson2314
doc: chap cross: Make example command stick out more

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e316ba1 
It should be in a <programlisting>, not <command>, tag.
@Ericson2314
doc: Cross chapter: Add note on why use example platforms
94a2af9
@Ericson2314 Ericson2314 added 6.topic: cross-compilation Building packages on a different platform than they will be used on 8.has: documentation This PR adds or changes documentation labels Jan 26, 2018
@hSloan
Copy link
Contributor

hSloan commented Jan 26, 2018

Awesome! Thanks for this!

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 26, 2018
@Ericson2314 Ericson2314 merged commit bc3c3b8 into NixOS:master Jan 26, 2018
@Ericson2314 Ericson2314 deleted the cross-doc branch January 26, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @hSloan @GrahamcOfBorg