Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero-gui: init at 0.11.1.0 #34311

Merged
merged 2 commits into from Jan 28, 2018
Merged

monero-gui: init at 0.11.1.0 #34311

merged 2 commits into from Jan 28, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 27, 2018

Motivation for this change

Provide a user friendly interface to Monero.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binaries, icons and translations
  • Tested blockchain synchronization and mining
  • Fits CONTRIBUTING.md.
Notes on patches
  • build-wallet-rpc.patch is based on an (yet) unreleased commit and is needed to build both libmonero-wallet and wallet-rpc binary at the same time.
    This should be removed on the next Monero update.

  • move-log-file changes the location of the log file to $XDG_CACHE_HOME or its equivalent on other OSes because it's hardcoded to the binary's own directory, in the nix store and therefore read-only.

  • move-translations-dir changes the location of the translations files from the binary directory (bin/ in this case) to share/


cc @ehmry

@rnhmjoj rnhmjoj changed the title Monero monero-gui: init at 0.11.1.0 Jan 27, 2018
@ehmry ehmry self-assigned this Jan 27, 2018
@ehmry ehmry merged commit 05cb4dc into NixOS:master Jan 28, 2018
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 28, 2018

@ehmry Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants