Remove TestArray#test_uniq_bang_with_freeze exclusion test case #5014
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nomadium This test is also on 9.1.x so I am cherry-picking this back. When possible when you notice these check jruby-9.1 branch first so it is a little easier for us (we regularly merge jruby-9.1 against master). |
|
@enebo Cool, will do on the next ocassion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I noticed one assertion in the excluded test
TestArray#test_uniq_bang_with_freezewas failing becauseuniq_bang19method inRubyArrayclass was not checking if the RubyArray instance can be modified after evaluating the passed block.With this proposed change, if correct, the test should pass.
MRI does something similar.
They do a check at the beginning of the method [1] and other after checking if a block was given [2].
Thanks for your review and feedback.