Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: Turn fork URL into a Markdown link #5644

Merged
merged 1 commit into from Apr 10, 2018
Merged

init: Turn fork URL into a Markdown link #5644

merged 1 commit into from Apr 10, 2018

Conversation

woodruffw
Copy link
Contributor

This is a pretty small change: it just turns the fork URL generated by crystal init into a real Markdown link. GitHub does this automatically for things that look like URLs, but adding the angle brackets should please a broader range of Markdown parsers.

Old:

1. Fork it ( https://github.com/woodruffw/whatever/fork )

New:

1. Fork it (<https://github.com/woodruffw/whatever/fork>)

@oprypin
Copy link
Member

oprypin commented Jan 27, 2018

This is nice. Could also add backticks to commands

@woodruffw
Copy link
Contributor Author

I did that in #5475 🙂

@Sija
Copy link
Contributor

Sija commented Apr 9, 2018 •
edited

Low-hanging 🍏 (fruit), merge?

@bcardiff bcardiff added this to the Next milestone Apr 10, 2018
@bcardiff bcardiff merged commit f91af5f into crystal-lang:master Apr 10, 2018
@woodruffw woodruffw deleted the linkify-fork branch April 10, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:compiler topic:tools
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@woodruffw @oprypin @Sija @jhass @straight-shoota @RX14 @bcardiff