lib, glibc: Get rid of withTLS #34303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added
the
6.topic: cross-compilation
dezgeg
reviewed
Jan 26, 2018
| @@ -191,7 +190,7 @@ stdenv.mkDerivation ({ | |||
| libc_cv_c_cleanup=yes | |||
| libc_cv_gnu89_inline=yes | |||
| # Only due to a problem in gcc configure scripts: | |||
| libc_cv_sparc64_tls=${if cross.withTLS then "yes" else "no"} | |||
| libc_cv_sparc64_tls=yes | |||
There was a problem hiding this comment.
I think this is unused now as well.
There was a problem hiding this comment.
Oh figured as much and was going to try to make this not a cross mass rebuild, but it is already. Good catch.
glibc removed the underlying flag in 2011 in 83cd14204559abbb52635006832eaf4d2f42514a [1]. This gets us one step closer to fixing NixOS#34274: the cross stdenv for aarch64-unknown-linux-gnu at least evals now. Thanks to @dezgeg for doing all the research for this. [1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=83cd14204559abbb52635006832eaf4d2f42514a
Ericson2314
force-pushed
the
glibc-always-tls
branch
from
d52ffea
to
8a20c0e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc removed the underlying flag in 2011 in 83cd14204559abbb52635006832eaf4d2f42514a 1.
This gets us one step closer to fixing #34274: the cross stdenv for aarch64-unknown-linux-gnu at least evals now.
Thanks to @dezgeg for doing all the research for this.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)